Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Allow More Custom Tags #67

Open
Open
@aterris

Description

@aterris

Looking through the code I noticed that you have limited custom tags in b6868b1

I ran into this as I was trying to add some custom tags to some of my custom metrics. I was wondering if you could shed any light on the context behind that change?

I was thinking about doing one of the following...

  1. Updating docs to reflect that
  2. Remove the constraint entirely
  3. Enable setting allowed custom tags via environment variable

Before I made a PR, I wanted to understand why you made that change in the first place.

Activity

w-vi

w-vi commented on Feb 15, 2018

@w-vi
Contributor

Yes they are limited because datadog does not handle very well if you have loads of them. This list should actually be configurable but apparently this has never happened. I this having the list defined by environment variable is a good approach so if you have a PR ready then please go ahead.

aterris

aterris commented on Feb 15, 2018

@aterris
Author

Not quite ready but should be able to create one soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @aterris@w-vi

        Issue actions

          Allow More Custom Tags · Issue #67 · apiaryio/heroku-datadog-drain-golang