Skip to content

Integration tests make real requests to api.apify.com #21

Description

@Pijukatel

19 of the 22 integration test files never point APIFY_UPSTREAM_API_BASE_URL anywhere, so every user creation in them sends a real request to https://api.apify.com/v2/users/me. Only api-fallback.test.ts, identity-resolution.test.ts and settings-console.test.ts redirect it.

This is invisible in a sandbox with blocked egress — the probe fails and the runtime falls back to local identity, so the suite passes either way. On a developer's own machine it is real, unthrottled outbound traffic to Apify's production API on every test run.

Pre-existing; predates the upstream-fallback work (#20). Found while reviewing that change.

A default in test/integration/helpers/test-server.ts pointing the variable at a dead address unless a test sets it otherwise would cover every file at once.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions