Skip to content

Commit 8ca4874

Browse files
committed
chore: claude review 1
1 parent 0ca46b1 commit 8ca4874

1 file changed

Lines changed: 40 additions & 16 deletions

File tree

Makefile

Lines changed: 40 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ define cleanup-firefox-certs
3535
@rm -rf ./$(1)/firefox-certs
3636
endef
3737

38-
ALL_ARM_TESTS = test-node-arm test-node-playwright-arm test-node-playwright-chrome-arm test-node-playwright-firefox-arm test-node-playwright-webkit-arm test-node-puppeteer-chrome-arm test-python-arm test-python-playwright-arm test-python-selenium-arm
39-
ALL_ARM_NODE_TESTS = test-node-arm test-node-playwright-arm test-node-playwright-chrome-arm test-node-playwright-firefox-arm test-node-playwright-webkit-arm test-node-puppeteer-chrome-arm
38+
ALL_ARM_TESTS = test-node-arm test-node-playwright-arm test-node-playwright-chrome-arm test-node-playwright-firefox-arm test-node-playwright-webkit-arm test-node-playwright-camoufox-arm test-node-puppeteer-chrome-arm test-python-arm test-python-playwright-arm test-python-selenium-arm
39+
ALL_ARM_NODE_TESTS = test-node-arm test-node-playwright-arm test-node-playwright-chrome-arm test-node-playwright-firefox-arm test-node-playwright-webkit-arm test-node-playwright-camoufox-arm test-node-puppeteer-chrome-arm
4040
ALL_ARM_PYTHON_TESTS = test-python-arm test-python-playwright-arm test-python-selenium-arm
4141

4242
what-tests:
@@ -92,6 +92,42 @@ all-python:
9292
@echo ""
9393
@echo "All python tests done!"
9494

95+
all-arm:
96+
@echo "Running all arm tests, this will take a while..."
97+
98+
@for test in $(ALL_ARM_TESTS); do \
99+
echo "Running $$test"; \
100+
$(MAKE) $$test; \
101+
echo "Done $$test"; \
102+
done
103+
104+
@echo ""
105+
@echo "All arm tests done!"
106+
107+
all-arm-node:
108+
@echo "Running all arm node tests, this will take a while..."
109+
110+
@for test in $(ALL_ARM_NODE_TESTS); do \
111+
echo "Running $$test"; \
112+
$(MAKE) $$test; \
113+
echo "Done $$test"; \
114+
done
115+
116+
@echo ""
117+
@echo "All arm node tests done!"
118+
119+
all-arm-python:
120+
@echo "Running all arm python tests, this will take a while..."
121+
122+
@for test in $(ALL_ARM_PYTHON_TESTS); do \
123+
echo "Running $$test"; \
124+
$(MAKE) $$test; \
125+
echo "Done $$test"; \
126+
done
127+
128+
@echo ""
129+
@echo "All arm python tests done!"
130+
95131
test-node:
96132
@echo "Building node with version $(NODE_VERSION) (overwrite using NODE_VERSION=XX)"
97133

@@ -306,21 +342,9 @@ test-node-puppeteer-chrome:
306342
docker rmi apify/node-puppeteer-chrome:local
307343

308344
test-node-puppeteer-chrome-arm:
309-
@echo "Building puppeteer-chrome arm64 with version $(PUPPETEER_VERSION) (overwrite using PUPPETEER_VERSION=22.6.2) and node version $(NODE_VERSION) (overwrite using NODE_VERSION=XX)"
310-
311-
@# Correct package.json
312-
@APIFY_VERSION=latest CRAWLEE_VERSION=latest PUPPETEER_VERSION=$(PUPPETEER_VERSION) node ./scripts/update-package-json.mjs ./node-puppeteer-chrome
313-
314-
docker buildx build --platform linux/arm64 --build-arg NODE_VERSION=$(NODE_VERSION) --file ./node-puppeteer-chrome/Dockerfile --tag apify/node-puppeteer-chrome:local --load ./node-puppeteer-chrome
315-
docker run --rm -it --platform linux/arm64 apify/node-puppeteer-chrome:local
316-
317-
@# Restore package.json
318-
@git checkout ./node-puppeteer-chrome/package.json 1>/dev/null 2>&1
319-
320-
@# Delete docker image
321-
docker rmi apify/node-puppeteer-chrome:local
345+
@echo "Not supported due to Chrome lacking support for arm64 on Linux"
346+
@exit 1
322347

323-
test-node-puppeteer-chrome-arm:
324348
@echo "Building puppeteer-chrome arm64 with version $(PUPPETEER_VERSION) (overwrite using PUPPETEER_VERSION=22.6.2) and node version $(NODE_VERSION) (overwrite using NODE_VERSION=XX)"
325349

326350
@# Correct package.json

0 commit comments

Comments
 (0)