Fix error handling to exit with code 1 on command errors

Co-authored-by: B4nan <615580+B4nan@users.noreply.github.com>

Author: Copilot

src/lib/command-framework/apify-command.ts

@@ -301,15 +301,17 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 
 		if (missingRequiredArgs.size) {
 			this._printMissingRequiredArgs(missingRequiredArgs);
-			return;
 		}
 
 		this._parseFlags(rawFlags, rawTokens);
 
+		let hadError: Error | null = null;
+
 		try {
 			await this.run();
 		} catch (err: any) {
 			error({ message: err.message });
+			hadError = err;
 		} finally {
 			// analytics
 			if (!this.telemetryData.actorLanguage && COMMANDS_WITHIN_ACTOR.includes(this.commandString)) {
@@ -336,6 +338,15 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 					this.telemetryData,
 				);
 			}
+
+			if (hadError) {
+				// In test mode (skipTelemetry=true), throw the error so tests can catch it
+				// In normal mode, exit with code 1
+				if (this.skipTelemetry) {
+					throw hadError;
+				}
+				process.exit(1);
+			}
 		}
 	}
 
@@ -588,7 +599,7 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 		}
 	}
 
-	private _printMissingRequiredArgs(missingRequiredArgs: Map<string, TaggedArgBuilder<ArgTag, unknown>>) {
+	private _printMissingRequiredArgs(missingRequiredArgs: Map<string, TaggedArgBuilder<ArgTag, unknown>>): never {
 		const help = selectiveRenderHelpForCommand(this.ctor, {
 			showUsageString: true,
 		});
@@ -616,6 +627,8 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 				help,
 			].join('\n'),
 		});
+
+		process.exit(1);
 	}
 
 	private _handleStdin(mode: StdinMode) {

test/local/commands/secrets/add.test.ts

@@ -16,6 +16,16 @@ describe('apify secrets add', () => {
 		}
 	});
 
+	afterEach(async () => {
+		// Clean up after each test
+		const secrets = getSecretsFile();
+		if (secrets[SECRET_KEY]) {
+			await testRunCommand(SecretsRmCommand, {
+				args_name: SECRET_KEY,
+			});
+		}
+	});
+
 	it('should work', async () => {
 		await testRunCommand(SecretsAddCommand, {
 			args_name: SECRET_KEY,
@@ -26,13 +36,19 @@ describe('apify secrets add', () => {
 		expect(secrets[SECRET_KEY]).to.eql(SECRET_VALUE);
 	});
 
-	afterAll(async () => {
-		const secrets = getSecretsFile();
+	it('should throw error when adding duplicate secret', async () => {
+		// First add a secret
+		await testRunCommand(SecretsAddCommand, {
+			args_name: SECRET_KEY,
+			args_value: SECRET_VALUE,
+		});
 
-		if (secrets[SECRET_KEY]) {
-			await testRunCommand(SecretsRmCommand, {
+		// Try to add the same secret again and expect it to throw
+		await expect(
+			testRunCommand(SecretsAddCommand, {
 				args_name: SECRET_KEY,
-			});
-		}
+				args_value: SECRET_VALUE,
+			}),
+		).rejects.toThrow(`Secret with name ${SECRET_KEY} already exists`);
 	});
 });