feat: review feedback changes [internal]

Author: Janjiran

docs/reference.md

@@ -1655,14 +1655,15 @@ FLAGS
 DESCRIPTION
   Publishes the task on its public landing page.
   The task must belong to a public Actor and have its public display 
-  configuration set up (in Apify Console, on the task Publication tab).
+  configuration set up (in Apify Console, on the task Publication tab). Requires
+   write access to the task and to its Actor.
 
 USAGE
   $ apify task publish <taskId>
 
 ARGUMENTS
-  taskId  Name or ID of the Task to publish (e.g. "my-task" or
-          "E2jjCZBezvAZnX8Rb").
+  taskId  Name of the Task to publish, or its full name (e.g. "my-task" or
+          "username/my-task").
 ```
 
 ##### `apify task unpublish`
@@ -1671,14 +1672,14 @@ ARGUMENTS
 DESCRIPTION
   Unpublishes the task from its public landing page.
   The public display configuration is preserved, so the task can be published 
-  again later.
+  again later. Requires write access to the task and to its Actor.
 
 USAGE
   $ apify task unpublish <taskId>
 
 ARGUMENTS
-  taskId  Name or ID of the Task to unpublish (e.g. "my-task" or
-          "E2jjCZBezvAZnX8Rb").
+  taskId  Name of the Task to unpublish, or its full name (e.g. "my-task"
+          or "username/my-task").
 ```
 <!-- task-commands-end -->
 <!-- prettier-ignore-end -->

src/commands/task/publish.ts

@@ -3,6 +3,7 @@ import chalk from 'chalk';
 
 import { ApifyCommand } from '../../lib/command-framework/apify-command.js';
 import { Args } from '../../lib/command-framework/args.js';
+import { CommandExitCodes } from '../../lib/consts.js';
 import { error, success } from '../../lib/outputs.js';
 import { getLocalUserInfo, getLoggedClientOrThrow } from '../../lib/utils.js';
 
@@ -12,16 +13,17 @@ export class TaskPublishCommand extends ApifyCommand<typeof TaskPublishCommand>
 	static override description =
 		'Publishes the task on its public landing page.\n' +
 		'The task must belong to a public Actor and have its public display configuration set up ' +
-		'(in Apify Console, on the task Publication tab).';
+		'(in Apify Console, on the task Publication tab). ' +
+		'Requires write access to the task and to its Actor.';
 
 	static override examples = [
 		{
 			description: 'Publish a task by name.',
 			command: 'apify task publish my-task',
 		},
 		{
-			description: 'Publish a task by full ID.',
-			command: 'apify task publish E2jjCZBezvAZnX8Rb',
+			description: 'Publish a task by its full name.',
+			command: 'apify task publish username/my-task',
 		},
 	];
 
@@ -30,7 +32,7 @@ export class TaskPublishCommand extends ApifyCommand<typeof TaskPublishCommand>
 	static override args = {
 		taskId: Args.string({
 			required: true,
-			description: 'Name or ID of the Task to publish (e.g. "my-task" or "E2jjCZBezvAZnX8Rb").',
+			description: 'Name of the Task to publish, or its full name (e.g. "my-task" or "username/my-task").',
 		}),
 	};
 
@@ -45,7 +47,8 @@ export class TaskPublishCommand extends ApifyCommand<typeof TaskPublishCommand>
 
 		const task = await taskClient.get();
 		if (!task) {
-			error({ message: `Cannot find Task with ID or name '${taskId}' in your account.` });
+			error({ message: `Cannot find Task with name '${taskId}' in your account.` });
+			process.exitCode = CommandExitCodes.NotFound;
 			return;
 		}
 
@@ -62,6 +65,7 @@ export class TaskPublishCommand extends ApifyCommand<typeof TaskPublishCommand>
 			error({
 				message: `Failed to publish Task ${chalk.yellow(task.name)}\n  ${casted.message || casted}`,
 			});
+			process.exitCode = CommandExitCodes.RunFailed;
 		}
 	}
 }

src/commands/task/unpublish.ts

@@ -3,6 +3,7 @@ import chalk from 'chalk';
 
 import { ApifyCommand } from '../../lib/command-framework/apify-command.js';
 import { Args } from '../../lib/command-framework/args.js';
+import { CommandExitCodes } from '../../lib/consts.js';
 import { error, success } from '../../lib/outputs.js';
 import { getLocalUserInfo, getLoggedClientOrThrow } from '../../lib/utils.js';
 
@@ -11,16 +12,17 @@ export class TaskUnpublishCommand extends ApifyCommand<typeof TaskUnpublishComma
 
 	static override description =
 		'Unpublishes the task from its public landing page.\n' +
-		'The public display configuration is preserved, so the task can be published again later.';
+		'The public display configuration is preserved, so the task can be published again later. ' +
+		'Requires write access to the task and to its Actor.';
 
 	static override examples = [
 		{
 			description: 'Unpublish a task by name.',
 			command: 'apify task unpublish my-task',
 		},
 		{
-			description: 'Unpublish a task by full ID.',
-			command: 'apify task unpublish E2jjCZBezvAZnX8Rb',
+			description: 'Unpublish a task by its full name.',
+			command: 'apify task unpublish username/my-task',
 		},
 	];
 
@@ -29,7 +31,7 @@ export class TaskUnpublishCommand extends ApifyCommand<typeof TaskUnpublishComma
 	static override args = {
 		taskId: Args.string({
 			required: true,
-			description: 'Name or ID of the Task to unpublish (e.g. "my-task" or "E2jjCZBezvAZnX8Rb").',
+			description: 'Name of the Task to unpublish, or its full name (e.g. "my-task" or "username/my-task").',
 		}),
 	};
 
@@ -44,7 +46,8 @@ export class TaskUnpublishCommand extends ApifyCommand<typeof TaskUnpublishComma
 
 		const task = await taskClient.get();
 		if (!task) {
-			error({ message: `Cannot find Task with ID or name '${taskId}' in your account.` });
+			error({ message: `Cannot find Task with name '${taskId}' in your account.` });
+			process.exitCode = CommandExitCodes.NotFound;
 			return;
 		}
 
@@ -61,6 +64,7 @@ export class TaskUnpublishCommand extends ApifyCommand<typeof TaskUnpublishComma
 			error({
 				message: `Failed to unpublish Task ${chalk.yellow(task.name)}\n  ${casted.message || casted}`,
 			});
+			process.exitCode = CommandExitCodes.RunFailed;
 		}
 	}
 }