In PlaywrightCrawler.failedRequestHandler() the error argument contains no information about error

[stargazer33]

Which package is this bug report for? If unsure which one to select, leave blank

None

Issue description

I need access to the information about error in my code, so I use PlaywrightCrawler.failedRequestHandler() and .errorHandler to handle errors and to access the error information.

But the error argument of these methods contains no info!
At the same time - the console log contains all the details about the error!
So this should be fixed, the error argument should have the same/similar info as on the console.

Attached the code to reproduce this. I changed the httpbin.org to httpbin.or to produce errors.
On the console I see:

ERROR PlaywrightCrawler: Request failed and reached maximum retries. page.goto: NS_ERROR_NET_RESET
=========================== logs ===========================
navigating to "https://httpbin.or/headers#gsphgfh", waiting until "load"
============================================================

And when I print the contents of the error argument I get only this:

WARN  PlaywrightCrawler: failedRequestHandler: error={"name":"Error"}

Well, "name":"Error" is not really helpfull!

Code sample

import { firefox, webkit } from 'playwright';
import { PlaywrightCrawler, Dataset, ProxyConfiguration, Request, log, sleep } from 'crawlee';
import { launchPlaywright, playwrightUtils } from 'crawlee';
import * as crypt from 'crypto';

const crawler = new PlaywrightCrawler({
    maxRequestRetries: 0,
    navigationTimeoutSecs: 25,
    requestHandlerTimeoutSecs: 20,
    useSessionPool: false,
    persistCookiesPerSession: false,
    headless: true,
    browserPoolOptions: {
        useFingerprints: true,
	    operationTimeoutSecs: 30,
    },
    launchContext: {
	    useIncognitoPages: true,
	    launcher: firefox
    },

    async requestHandler( {request, response, page, enqueueLinks, log, proxyInfo} )
    {
        let scrFile = `httpbin-${request.uniqueKey}.png`;
        await sleep(15*1000);
        log.info(`GET ${request.url}  Writing into ${scrFile} ...`);
        await page.screenshot( {path:scrFile, fullPage:false} );
        log.info(`GET ${request.url}  DONE`);
    },

    async errorHandler({request, response, page, log}, error)
    {
        let errorStr = JSON.stringify(error);
        log.warning(`errorHandler: error=${errorStr}` );
    },

    async failedRequestHandler({request, response, page, log}, error) {
        let errorStr = JSON.stringify(error);
        log.warning(`failedRequestHandler: error=${errorStr}` );
    },
});

await crawler.addRequests([ new Request({ url: "https://httpbin.or/headers#gsphgfh", uniqueKey: "gsphgfh" }) ]);
await crawler.run([]);

Package version

[email protected]

Node.js version

node v16.19.0, [email protected]

Operating system

Ubuntu

Apify platform

• Tick me if you encountered this issue on the Apify platform

I have tested this on the next release

No response

Other context

No response

[B4nan]

The same error info is there, it just gets lost when you convert the error object to JSON. That's how errors works in JS, not really a problem on our end:

The problem here is that the error properties like message or stack are not enumerable, so they won't make it into the JSON string.

[stargazer33]

@B4nan - you are right, the err.message= contains the text I see on the console.

Thanks for quick response!