Skip to content

Commit e89bdf2

Browse files
authored
Merge pull request #68 from osher/patch-2
private attrs should be stripped from params too
2 parents 833c3b1 + 4be9b8d commit e89bdf2

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

fittings/swagger_raw.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,18 @@ function filterKeysRecursive(object, dropTagRegex, privateTags) {
6060
debug('dropping object at %s', key);
6161
delete(result[key]);
6262
}
63+
} else {
64+
debug("dropping value at %s", key)
6365
}
6466
});
6567
return result;
6668
}
69+
} else if (Array.isArray(object) ) {
70+
object = object.reduce(function(reduced, value) {
71+
var v = filterKeysRecursive(value, dropTagRegex, privateTags);
72+
if (v !== undefined) reduced.push(v);
73+
return reduced
74+
}, [])
6775
}
6876
return object;
6977
}

test/assets/project/api/swagger/swagger.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ paths:
2222
description: The name of the person to whom to say hello
2323
required: false
2424
type: string
25+
x-remove-me: lol
2526
responses:
2627
200:
2728
description: Success

test/fittings/swagger_raw.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ describe('swagger_raw', function() {
1818

1919
var filteredSwagger = _.cloneDeep(swagger);
2020
delete(filteredSwagger.paths['/invalid_header']);
21+
delete(filteredSwagger.paths['/hello'].get.parameters[0]['x-remove-me'])
2122

2223
// hokey algorithm, but at least it's different than the one it's testing
2324
var OMIT = ['x-swagger-router-controller', 'x-swagger-pipe', 'x-hidden', 'x-private', 'x-controller-interface'];

0 commit comments

Comments
 (0)