Use "foreign_cc" rules to build libev.

This should be more portable than trying to write
our own genrule to do it, which was breaking on Homebrew.
Also, fix the foreign_cc rules so that they work on BSD.

Author: gbrail

WORKSPACE

@@ -8,6 +8,19 @@ load(
     "new_git_repository",
 )
 
+git_repository(
+   name = "rules_foreign_cc",
+   commit = "38358597f9380e9098eb5642169ad23c169df98e",
+   remote = "https://github.com/gbrail/rules_foreign_cc.git",
+   shallow_since = "1586453104 -0700"
+)
+load("@rules_foreign_cc//:workspace_definitions.bzl", "rules_foreign_cc_dependencies")
+
+rules_foreign_cc_dependencies([])
+
+# Group the sources of the library so that make rule have access to it
+all_content = """filegroup(name = "all", srcs = glob(["**"]), visibility = ["//visibility:public"])"""
+
 http_archive(
     name = "gtest",
     sha256 = "9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb",
@@ -17,10 +30,10 @@ http_archive(
 
 http_archive(
     name = "libev",
-    build_file = "@//:libev.build",
-    sha256 = "2d5526fc8da4f072dd5c73e18fbb1666f5ef8ed78b73bba12e195cfdd810344e",
-    strip_prefix = "libev-4.27",
-    urls = ["http://dist.schmorp.de/libev/Attic/libev-4.27.tar.gz"],
+    sha256 = "507eb7b8d1015fbec5b935f34ebed15bf346bed04a11ab82b8eee848c4205aea",
+    strip_prefix = "libev-4.33",
+    build_file_content = all_content,
+    urls = ["http://dist.schmorp.de/libev/Attic/libev-4.33.tar.gz"],
 )
 
 http_archive(

apib/BUILD

@@ -79,11 +79,11 @@ cc_library(
     deps = [
         ":common",
         "//third_party:base64",
+        "//third_party/libev",
         "@absl//absl/strings:str_format",
         "@boringssl//:crypto",
         "@boringssl//:ssl",
         "@httpparser",
-        "@libev",
     ],
 )
 
@@ -97,8 +97,8 @@ cc_library(
     ],
     deps = [
         ":common",
+        "//third_party/libev",
         "@absl//absl/strings",
-        "@libev",
     ],
     linkopts = [
         "-lpthread",

libev.build

@@ -4,9 +4,9 @@ cc_library(
     hdrs = ["test_server.h"],
     deps = [
         "//apib:common",
+        "//third_party/libev",
         "@boringssl//:ssl",
         "@httpparser",
-        "@libev",
     ],
 )
 
@@ -112,6 +112,7 @@ cc_test(
         "//apib:io",
         "@gtest",
     ],
+    linkstatic = True,
 )
 
 cc_test(
@@ -123,6 +124,7 @@ cc_test(
         "//apib:io",
         "@gtest",
     ],
+    linkstatic = True,
 )
 
 cc_test(

libevent.build

@@ -0,0 +1,20 @@
+package(default_visibility = ["//visibility:public"])
+
+load("@rules_foreign_cc//tools/build_defs:configure.bzl", "configure_make")
+
+configure_make(
+  name = "libev",
+  lib_source = "@libev//:all",
+  configure_options = [
+    "--disable-dependency-tracking",
+    "--enable-static",
+    "--disable-shared",
+  ],
+  # Without this for some reason Bazel tries to send
+  # ar commands to libtool!
+  configure_env_vars = {
+    "AR": "",
+  },
+  # Bazel likes to use the shared libraries for tests
+  static_libraries = ["libev.a"],
+)