Merge pull request #741 from apinf/feature/publish-api-backend-on-update

Feature/publish api backend on update. Closes #713

Author: frenchbread

client/views/api_backends/add-backend-workflow/wizard.js

@@ -103,15 +103,18 @@ Template.addApiBackendWizard.helpers({
 
           // Set frontend host to API Umbrella host value
           apiBackend.frontend_host = apiUmbrellaHost;
-          
+
           // Create the API Backend on API Umbrella
           Meteor.call('createApiBackendOnApiUmbrella', apiBackend, function(error, apiUmbrellaWebResponse) {
             if (apiUmbrellaWebResponse.http_status === 200) {
+              // Get API Backend from API Umbrella response
+              var apiBackend = apiUmbrellaWebResponse.result.data.api;
+
               // Insert the API Backend
               var apiBackendId = ApiBackends.insert(apiBackend);
 
               // Get the ID of the newly created API Backend
-              var apiUmbrellaApiId = apiUmbrellaWebResponse.result.data.api.id;
+              var apiUmbrellaApiId = apiBackend.id;
 
               // Tell Wizard the submission is complete
               context.done();

client/views/api_backends/api_backend_form/autoform.js

@@ -44,6 +44,61 @@ AutoForm.hooks({
             context.result(false);
           }
         });
+      },
+      update: function (apiBackendForm) {
+        // Keep the context to use inside the callback function
+        var context = this;
+
+        // Get current API Backend document for modification
+        var apiBackend = context.currentDoc;
+
+        // Get the set of updated properties
+        var setApiBackendProperties = context.updateDoc.$set;
+
+        // Get the set of properties to remove
+        var unsetApiBackendProperties = context.updateDoc.$unset;
+
+        // Update properties on API Backend document
+        for (let property in setApiBackendProperties) {
+          apiBackend[property] = setApiBackendProperties[property];
+        }
+
+        // Delete unused properties from API Backend object
+        for (let property in unsetApiBackendProperties) {
+          delete apiBackend[property];
+        }
+
+        // Get ID of API Umbrella backend (not the Apinf document ID)
+        var apiUmbrellaBackendId = apiBackend.id;
+
+        // Send the API Backend to API Umbrella
+        response = Meteor.call(
+          'updateApiBackendOnApiUmbrella',
+          apiUmbrellaBackendId,
+          apiBackend,
+          function(error, apiUmbrellaWebResponse) {
+            // Check for API Umbrella error
+            if (apiUmbrellaWebResponse.http_status === 204) {
+              // If status is OK, submit form
+              context.result(apiBackendForm);
+            } else {
+              // If there are errors
+              var errors = _.values(apiUmbrellaWebResponse.errors);
+
+              // Flatten all error descriptions to show using sAlert
+              errors = _.flatten(errors);
+              _.each(errors, function(error) {
+                //Display error to the user, keep the sAlert box visible.
+                sAlert.error(error, {timeout: 'none'});
+                // TODO: Figure out a way to send the errors back to the autoform fields, as if it were client validation,
+                //   and get rid of sAlert here.
+              });
+
+              // Cancel form submission on error,
+              // so user see the error message and edit the incorrect fields
+              context.result(false);
+            }
+        });
       }
     },
     onSuccess: function () {
@@ -81,11 +136,13 @@ AutoForm.hooks({
 
       // Publish the API Backend on API Umbrella
       Meteor.call('publishApiBackendOnApiUmbrella', apiUmbrellaApiId, function(error, apiUmbrellaWebResponse) {
-        console.log(apiUmbrellaWebResponse);
 
+        // Check for a successful response
         if (apiUmbrellaWebResponse.http_status === 201) {
+          // Alert the user of the success
           sAlert.success("API Backend successfully published.");
         } else {
+          // If there are errors, inform the user
           var errors = _.values(apiUmbrellaWebResponse.errors);
 
           // Flatten all error descriptions to show using sAlert

server/methods/apiBackends.js

@@ -61,5 +61,29 @@ Meteor.methods({
       apiUmbrellaWebResponse.http_status = 422;
     }
     return apiUmbrellaWebResponse;
+  },
+  updateApiBackendOnApiUmbrella: function (apiUmbrellaBackendId, apiBackend) {
+    // Construct an API Backend object for API Umbrella with one 'api' key
+    var constructedBackend = {
+      "api": apiBackend
+    };
+
+    // Response object to be send back to client layer.
+    var apiUmbrellaWebResponse = {
+      result: {},
+      http_status: 204,
+      errors: {}
+    };
+
+    try {
+      // Send the API Backend to API Umbrella's endpoint for creation in the backend
+      apiUmbrellaWebResponse.result = apiUmbrellaWeb.adminApi.v1.apiBackends.updateApiBackend(apiUmbrellaBackendId, constructedBackend);
+    } catch (apiUmbrellaError) {
+
+      //set the errors object
+      apiUmbrellaWebResponse.errors = {'default': [apiUmbrellaError.message]};
+      apiUmbrellaWebResponse.http_status = 422;
+    }
+    return apiUmbrellaWebResponse;
   }
 });

server/startup.js

@@ -54,5 +54,12 @@ Meteor.startup(function () {
     "backend_host": 1
   });
 
+  // Fetch all API Backends
+  var apiBackends = ApiBackends.find().fetch();
+
+  // Check each backend to see if it has API Umbrella ID
+  apiBackends.forEach(function (apiBackend) {console.log("id: ", apiBackend.id)});
+
+  // Initialize cron jobs
   SyncedCron.start();
 });