Skip to content

Commit b5cdb3f

Browse files
committed
Point the existing nil/NilClass pending spec at its tracking issue
This pending case already existed on master with a vague "side of effect of inference changes" reason. It's the same nil-doesn't-simplify-to-NilClass gap that's already tracked and fixed (pending merge) in castwide#1223 and #40. Make that traceable instead of leaving the next reader to rediscover it.
1 parent 29a1887 commit b5cdb3f

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

spec/complex_type/conforms_to_spec.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@ class Sub < Sup; end
8181
end
8282

8383
it 'handles singleton types compared against their literals' do
84-
pending 'side of effect of inference changes'
84+
# https://github.com/castwide/solargraph/issues/1196
85+
#
86+
# `nil` doesn't yet simplify to `NilClass` the way other literals
87+
# simplify to their class name. Fixed by
88+
# https://github.com/castwide/solargraph/pull/1223 (stacked:
89+
# https://github.com/apiology/solargraph/pull/40).
90+
pending 'nil does not yet simplify to NilClass (issue #1196, fixed by PR #1223)'
8591
exp = Solargraph::ComplexType::UniqueType.new('nil', rooted: true)
8692
inf = Solargraph::ComplexType::UniqueType.new('NilClass', rooted: true)
8793
match = inf.conforms_to?(api_map, exp, :method_call)

0 commit comments

Comments
 (0)