Skip to content

Commit 7f5ac93

Browse files
Merge pull request #7 from apivideo/add-video-style-attributes
Fix style attributes on instantiation
2 parents 482b2f4 + acb14d4 commit 7f5ac93

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Changelog
22
All changes to this project will be documented in this file.
33

4-
## [1.0.0] - 2022-06-23
4+
## [1.0.1] - 2022-06-23
55
- Add `videoStyleObjectFit` and `videoStyleTransform` attributes
66

77
## [0.1.3] - 2022-04-27

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@api.video/react-player",
3-
"version": "1.0.0",
3+
"version": "1.0.1",
44
"description": "api.video React player component",
55
"keywords": [
66
"player",

src/index.tsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,13 @@ export default class ApiVideoPlayer extends React.Component<ApiVideoPlayerProps,
138138
this.playerSdk.addEventListener("userinactive", () => this.props.onUserInactive && this.props.onUserInactive());
139139
this.playerSdk.addEventListener("volumechange", (v) => this.props.onVolumeChange && this.props.onVolumeChange(v.volume));
140140

141+
if(this.props.videoStyleObjectFit) {
142+
this.playerSdk.setVideoStyleObjectFit(this.props.videoStyleObjectFit);
143+
}
144+
145+
if(this.props.videoStyleTransform) {
146+
this.playerSdk.setVideoStyleTransform(this.props.videoStyleTransform);
147+
}
141148

142149
this.playerSdk.addEventListener("ready", () => {
143150
this.playerSdk.getVolume().then(d => this.props.onVolumeChange && this.props.onVolumeChange(d));
@@ -206,11 +213,11 @@ export default class ApiVideoPlayer extends React.Component<ApiVideoPlayerProps,
206213
if (nextProps.playbackRate !== undefined && nextProps.playbackRate !== this.props.playbackRate) {
207214
this.playerSdk.setPlaybackRate(nextProps.playbackRate);
208215
}
209-
if (nextProps.videoStyleObjectFit !== undefined && nextProps.videoStyleObjectFit !== this.props.videoStyleObjectFit) {
210-
this.playerSdk.setVideoStyleObjectFit(nextProps.videoStyleObjectFit);
216+
if (nextProps.videoStyleObjectFit !== this.props.videoStyleObjectFit) {
217+
this.playerSdk.setVideoStyleObjectFit(nextProps.videoStyleObjectFit || "none");
211218
}
212-
if (nextProps.videoStyleTransform !== undefined && nextProps.videoStyleTransform !== this.props.videoStyleTransform) {
213-
this.playerSdk.setVideoStyleTransform(nextProps.videoStyleTransform);
219+
if (nextProps.videoStyleTransform !== this.props.videoStyleTransform) {
220+
this.playerSdk.setVideoStyleTransform(nextProps.videoStyleTransform || "");
214221
}
215222

216223
if (nextProps.controls !== undefined) {

0 commit comments

Comments
 (0)