Change article model

Author: alexhernandezord

plugin/lib/Aplazame/Aplazame/BusinessModel/Article.php

@@ -14,44 +14,36 @@ public static function createFromOrderItem( $item ) {
 	}
 
 	public static function createFromOrderItemArray( array $values ) {
-		$productId = $values['product_id'];
-		$product   = new WC_Product( $values['product_id'] );
-
+		$product  = new WC_Product( $values['product_id'] );
+		$quantity = (int) $values['qty'];
+		$price    = $values['line_subtotal'] / $values['qty'];
 		$tax_rate = 100 * ( $values['line_tax'] / $values['line_total'] );
 
-		$aArticle           = new self();
-		$aArticle->id       = $productId;
-		$aArticle->sku      = $product->get_sku();
-		$aArticle->name     = $product->get_title();
-		$aArticle->url      = $product->get_permalink();
-		$aArticle->quantity = (int) $values['qty'];
-		$aArticle->price    = Aplazame_Sdk_Serializer_Decimal::fromFloat( $values['line_subtotal'] / $values['qty'] );
-		$aArticle->tax_rate = Aplazame_Sdk_Serializer_Decimal::fromFloat( $tax_rate );
-
-		$description = WC_Aplazame::_m_or_m( $product, 'get_post', 'get_post_data' )->post_content;
-		if ( ! empty( $description ) ) {
-			$aArticle->description = $description;
-		}
-
-		$imageUrl = wp_get_attachment_url( get_post_thumbnail_id( $productId ) );
-		if ( ! empty( $imageUrl ) ) {
-			$aArticle->image_url = $imageUrl;
-		}
-
-		return $aArticle;
+		return self::createArticle( $product, $quantity, $price, $tax_rate );
 	}
 
 	public static function createFromOrderItemProduct( WC_Order_Item_Product $item_product ) {
-		$product  = $item_product->get_product();
+		$product  = new WC_Product( $item_product->get_product_id() );
+		$quantity = (int) $item_product->get_quantity();
+		$price    = $item_product->get_subtotal() / $item_product->get_quantity();
 		$tax_rate = 100 * ( $item_product->get_total_tax() / $item_product->get_total() );
 
-		$aArticle           = new self();
-		$aArticle->id       = $product->get_id();
-		$aArticle->sku      = $product->get_sku();
-		$aArticle->name     = $product->get_title();
-		$aArticle->url      = $product->get_permalink();
-		$aArticle->quantity = (int) $item_product->get_quantity();
-		$aArticle->price    = Aplazame_Sdk_Serializer_Decimal::fromFloat( $item_product->get_subtotal() / $item_product->get_quantity() );
+		return self::createArticle( $product, $quantity, $price, $tax_rate );
+	}
+
+	private static function createArticle( WC_Product $product, $quantity, $price, $tax_rate ) {
+		$aArticle     = new self();
+		$aArticle->id = $product->get_id() ? $product->get_id() : null;
+
+		$sku = $product->get_sku();
+		if ( ! empty( $sku ) ) {
+			$aArticle->sku = $sku;
+		}
+
+		$aArticle->name     = $product->get_title() ? $product->get_title() : null;
+		$aArticle->url      = $product->get_permalink() ? $product->get_permalink() : null;
+		$aArticle->quantity = $quantity;
+		$aArticle->price    = Aplazame_Sdk_Serializer_Decimal::fromFloat( $price );
 		$aArticle->tax_rate = Aplazame_Sdk_Serializer_Decimal::fromFloat( $tax_rate );
 
 		$description = WC_Aplazame::_m_or_m( $product, 'get_post', 'get_post_data' )->post_content;