Skip to content

Conversation

@guittari
Copy link
Collaborator

@guittari guittari commented Mar 10, 2025

Minor changes:

  • Modified the introduction to include more content/address Adding a Preamble to the Documentation page #21
  • Introduced bold titles where appropriate (e.g., "My files are all in NWB and BIDS")
  • Changed certain titles to dark red
  • Updated general instructions

Larger changes:

  • Re-adjusted the "Download Data" section and moved it towards the top/I restructured the format to follow the guidelines from this reference. It may be worthwhile to re-evaluate the placement of the 'Download Data' section. Although this section references the initial step, 'Make sure you have the DANDI CLI tool installed,' it could potentially fit in several places. I believe placing sections like 'How do I download existing data?' after listing the conversion steps would be effective, though this is a very minor concern

Potential changes to consider:

  • I am considering adding a visual aid like the figure I created, which could enhance understanding from here:
EMBER-DANDI Upload Pipeline

@guittari guittari linked an issue Mar 10, 2025 that may be closed by this pull request
@guittari guittari requested review from nehatk17 and rhingo March 10, 2025 23:48
@NEStock
Copy link
Member

NEStock commented Mar 11, 2025

I went ahead and deployed this branch to http://ember-archive.jhuapl.edu:8080/documentation to make it easy for anyone to review!

@NEStock
Copy link
Member

NEStock commented Mar 11, 2025

For the Failing "Frontend CI / Run Prettier check": see updated README here: https://github.com/aplbrain/BBQS-EMBER-web/pull/26/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

I just realized that I added the GitHub Actions workflow but didn't update the README with any instructions, so I just created a branch doing that! Let me kno wif you have any questions though

@NEStock
Copy link
Member

NEStock commented Mar 11, 2025

Also, I think adding that visual would be useful!

Copy link
Member

@NEStock NEStock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the additions/changes look good to me!

@nehatk17
Copy link

Rahul reviewed the document and suggested adding some changes to the beginning section to clarify that users should check if their files are compatible with current NWB before selecting their upload workflow instructions. I updated the .md in Box '~/Box-Box/NIH BBQS EMBER/BBQS Community/DANDI Notes/Instructions for EMBER-DANDI/Instructions for Interfacing with the EMBER Archive.md' accordingly to change some wording and reorganize the instructions a little bit.

I think the way it displays in my markdown editor is a bit different from how it appears on the website. I agree that links to the section need to be implemented. In addition, there are a few callouts that aren't displaying that I think helps make the guide a bit more user-friendly. Having them be collapsible/foldable callouts would be ideal, not sure if that is possible on the website.

For example:

Note

My files are all NWB/BIDS compatible, do x,y,z

NEStock added 7 commits April 30, 2025 16:36
$ prettier --write "**/*.{js,ts,vue,scss,html,md,json}" --ignore-path .gitignore
.vscode/extensions.json 20ms (unchanged)
.vscode/settings.json 2ms (unchanged)
eslint.config.js 12ms (unchanged)
index.html 21ms (unchanged)
package.json 2ms (unchanged)
postcss.config.js 3ms (unchanged)
quasar.config.ts 33ms (unchanged)
README.md 25ms (unchanged)
scripts/fetchProjectMetadata.ts 20ms (unchanged)
src/App.vue 3ms (unchanged)
src/components/LinkText.vue 9ms (unchanged)
src/components/PageTitle.vue 3ms (unchanged)
src/constants/about.ts 5ms (unchanged)
src/constants/links.ts 3ms (unchanged)
src/constants/mainLayout.ts 2ms (unchanged)
src/constants/projects.ts 33ms (unchanged)
src/css/app.scss 17ms (unchanged)
src/css/quasar.variables.scss 1ms (unchanged)
src/env.d.ts 2ms (unchanged)
src/layouts/MainLayout.vue 29ms (unchanged)
src/models/about.ts 1ms (unchanged)
src/models/common.ts 0ms (unchanged)
src/models/mainLayout.ts 1ms (unchanged)
src/models/projects.ts 7ms (unchanged)
src/pages/AboutPage.vue 15ms (unchanged)
src/pages/DocumentationPage.vue 18ms (unchanged)
src/pages/ErrorNotFound.vue 3ms (unchanged)
src/pages/GettingStartedPage.vue 7ms (unchanged)
src/pages/IndexPage.vue 9ms (unchanged)
src/pages/MetadataPage.vue 2ms (unchanged)
src/pages/PrivacyPolicy.vue 11ms (unchanged)
src/pages/ProjectsPage.vue 11ms (unchanged)
src/pages/TermsOfService.vue 30ms (unchanged)
src/pages/ToolsPage.vue 2ms (unchanged)
src/router/index.ts 3ms (unchanged)
src/router/routes.ts 2ms (unchanged)
src/utils/date.ts 2ms (unchanged)
src/utils/scroll.ts 1ms (unchanged)
tsconfig.json 1ms (unchanged)
tsconfig.vue-tsc.json 1ms (unchanged)
Done in 0.83s.
…he-documentation-page

Documentation Page updates
@NEStock NEStock merged commit bbaf844 into main May 6, 2025
3 checks passed
@NEStock NEStock deleted the 21-adding-a-preamble-to-the-documentation-page branch May 6, 2025 15:39
@NEStock NEStock mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a Preamble to the Documentation page

5 participants