-
Notifications
You must be signed in to change notification settings - Fork 1
Updating "Getting Started" information #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
guittari
commented
Sep 10, 2025
- New Documentation Subpages
- Added a dedicated Standards page under the documentation section
- Covers: Overview, Data Standards (NWB/BIDS), Metadata Standards, Workflow Guidance, Validation Tools, and EMBER-specific Conventions
- Replaced old upload/download content with standards-focused expansion items
- Added a dedicated Workflow Guidance page
- Provides step-by-step instructions for ingest, validation, ancillary files, and submission
- Structured as expandable sections for clarity
- Added a dedicated Standards page under the documentation section
✅ Deploy Preview for emberarchive ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
erikjohnson24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes for added links/details!
| children: [ | ||
| { name: 'Documentation', route: '/documentation', external: false }, | ||
| { name: 'Standards Overview', route: '/standards', external: false }, | ||
| { name: 'Workflow Guidance', route: '/guidance', external: false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Data Ingest Guidnace" or "Data Upload Guidance" more accessible to users? I wonder if that will be easier for the non-expert user to quickly understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to adding extra words to describe which type of workflow this documentation is about (sometimes people have a lot of 'workflows' floating around for all kinds of things)
| <q-card-section> | ||
| <div class="text-h4 q-mb-md">Overview</div> | ||
| <p> | ||
| EMBER adopts community standards to enable interoperability and reproducibility across multimodal neuroscience datasets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EMBER has adopted?
| <div class="q-pa-md"> | ||
| <p>EMBER integrates widely used community standards for data organization:</p> | ||
| <ul> | ||
| <li><strong>NWB:</strong> for neurophysiology (ephys, behavior, optophysiology)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to hightlight suggested extensions? NDX-pose and NDX-wearables would make sense to start?
| </div> | ||
| </q-expansion-item> | ||
|
|
||
| <q-expansion-item label="Workflow Guidance" icon="directions" class="q-mt-sm"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update name per above? think about it!
| @@ -0,0 +1,77 @@ | |||
| <template> | |||
| <q-page class="column items-center"> | |||
| <PageTitle title="Workflow Guidance" subtitle="Steps for ingest, validation, and data submission" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, consider renaiming?
| <p>Convert or organize raw data into recognized community formats where possible:</p> | ||
| <ul> | ||
| <li>Use NWB for neurophysiology and behavioral time series</li> | ||
| <li>Use BIDS for imaging, EEG/MEG/iEEG, and derivatives</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to examples/how to from BIDS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some useful links
Converters: https://bids.neuroimaging.io/tools/converters.html
Tutorials: https://bids.neuroimaging.io/getting_started/tutorials/index.html
| <ul> | ||
| <li>Use NWB for neurophysiology and behavioral time series</li> | ||
| <li>Use BIDS for imaging, EEG/MEG/iEEG, and derivatives</li> | ||
| <li>Maintain consistent folder structures and naming conventions</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have specific recommendations here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just defer/copy & paste from Oliver's document to try to avoid duplication or writing something potentially inconsistent
| </div> | ||
| </q-expansion-item> | ||
|
|
||
| <q-expansion-item label="Step 3: Validate Data" icon="verified" class="q-mt-sm"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide example commands or links, and expected output for each vaildator? can probably link to or copy paste from relevant documentation?
| </div> | ||
| </q-expansion-item> | ||
|
|
||
| <q-expansion-item label="Step 4: Prepare Ancillary Files" icon="description" class="q-mt-sm"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have good examples to point to? maybe one of the existing project we've formatted, or from Dandi?
| <div class="q-pa-md"> | ||
| <ol> | ||
| <li>Ensure you have registered for EMBER-DANDI with your GitHub account</li> | ||
| <li>Use the DANDI CLI or UI to upload validated datasets</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to dandi cli code or add examples!
| </q-card-section> | ||
| </q-card> | ||
|
|
||
| <q-expansion-item label="Data Standards (NWB, BIDS)" icon="schema" class="q-mt-md"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the expandable format & the icons! Very clean and easy to read!
Minor UI nitpick: It wasn't immediately obvious to me that these were dropdowns (partially I think b/c I have a large screen and the dropdown icon is all the way on the right, away from the words)
I'm not sure what the best solution is here, but here are some ideas:
- adding a border about the expansion items?
- making the expansion componenent smaller (i.e. not the full width)
feel free to play around and see what looks best to you!
| <ul class="q-ml-lg q-mt-sm"> | ||
| <li>Use NWB for neurophysiology and behavioral time series</li> | ||
| <li>Use BIDS for imaging, EEG/MEG/iEEG, and derivatives</li> | ||
| <li>Maintain consistent folder structures and naming conventions</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to improve into
| <li>Maintain consistent folder structures and naming conventions</li> | |
| <li>Organize files and metadata following BIDS standard. In rare cases, "DANDI layout" organization of nwb and video files could suffice.</li> |
Co-authored-by: Yaroslav Halchenko <[email protected]>
| <a href="https://bids.neuroimaging.io/index.html" target="_blank" rel="noopener" class="link">BIDS</a> | ||
| and | ||
| <a href="https://nwb.org/about-nwb/" target="_blank" rel="noopener" class="link">NWB</a> | ||
| formats, along with hybrid layouts that combine both where appropriate, and anticipate accepting new standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| formats, along with hybrid layouts that combine both where appropriate, and anticipate accepting new standards. | |
| formats, along with hybrid layouts that combine both where appropriate. |
I'd suggest not planting abstract seeds of 'expectations' since 'who knows what will happen' in the future
Can (and should) always come back and modify the line if something changes later down the road
| <q-item-section> | ||
| <q-item-label overline>Scope</q-item-label> | ||
| <q-item-label> | ||
| Neurophysiology including ephys, behavior, optical physiology, and multimodal time series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Neurophysiology including ephys, behavior, optical physiology, and multimodal time series. | |
| Neurophysiology data, such as extracellular or intracellular electrophysiology (including EEG/iEEG), optical physiology, together with behavior, other multimodal time series, metadata tables, and annotated events. |
| <q-item-section> | ||
| <q-item-label overline>Scope</q-item-label> | ||
| <q-item-label> | ||
| MRI, EEG/MEG/iEEG, diffusion, functional, microscopy, behavioral logs, and derivatives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| MRI, EEG/MEG/iEEG, diffusion, functional, microscopy, behavioral logs, and derivatives. | |
| MRI/fMRI, EEG/MEG/iEEG, diffusion, microscopy, behavioral logs, and derivatives. |
Is this clearer?
Also is 'diffusion' clear enough on its own?
| <q-item-section> | ||
| <q-item-label overline>NWB Validation</q-item-label> | ||
| <q-item-label> | ||
| Validate with <code>pynwb validate</code> or NWBInspector for schema compliance and metadata completeness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Validate with <code>pynwb validate</code> or NWBInspector for schema compliance and metadata completeness. | |
| Validate with <a href="https://nwbinspector.readthedocs.io/en/dev/index.html" target="_blank" rel="noopener" class="link">NWB Inspector</a> for schema compliance and metadata completeness. |
To have one fewer thing to 'need to know'
FYI the NWB Inspector also runs and reports pynwb validate
| </q-item-label> | ||
| <q-item-label> | ||
| <ul class="q-ml-lg q-mt-sm"> | ||
| <li>Use NWB for neurophysiology and behavioral time series</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <li>Use NWB for neurophysiology and behavioral time series</li> | |
| <li>Convert data files to NWB format for neurophysiology and behavioral time series</li> |
| <q-item-label> | ||
| <ul class="q-ml-lg q-mt-sm"> | ||
| <li>Use NWB for neurophysiology and behavioral time series</li> | ||
| <li>Use file formats defined in BIDS for imaging, EEG/MEG/iEEG, and derivatives</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <li>Use file formats defined in BIDS for imaging, EEG/MEG/iEEG, and derivatives</li> | |
| <li>Use file formats defined in BIDS for imaging, EEG/MEG/iEEG (including NWB where applicable), and derivatives</li> |
| <!-- Step 2: Populate Metadata --> | ||
| <q-card flat class="q-mt-lg"> | ||
| <q-card-section> | ||
| <div class="text-h2 scrollable">Step 2: Populate Metadata</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great section to have, but for people to really walk away with something useful they will need practical examples
(which should be added in a separate PR IMO, so we can hash out or perfect items there)
Example: NCBI taxonomy format for species, UBERON codes for an anotomy or disorder, etc.
| <ul class="q-ml-lg q-mt-sm"> | ||
| <li>README files describing dataset contents and organization</li> | ||
| <li>Methodological notes or data processing scripts</li> | ||
| <li>Supplementary documentation (e.g., experimental protocols)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a policy decision to bring up to DCAIC perhaps; should we recommend/require use of protocols.io?
BICAN/BICCN used this to great effect: https://www.protocols.io/workspaces/biccn/publications
Though such things are much more common in the wet labs of pathology/histology
| <!-- Step 4: Prepare Ancillary Files --> | ||
| <q-card flat class="q-mt-lg"> | ||
| <q-card-section> | ||
| <div class="text-h2 scrollable">Step 4: Prepare Ancillary Files</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is interesting. While I appreciate it is there (and appreciate anyone who actually does it) one question is how are data submitters expected to include these ancillary files?
Without guidance (e.g., 'submit these files to a GitHub repository or Zenodo dataset and link that repository/dataset to this EMBER-Dandiset'), this section could be confusing
| <q-item-label overline>Submission</q-item-label> | ||
| <q-item-label> | ||
| <ol class="q-ml-lg q-mt-sm"> | ||
| <li>Ensure you have registered for EMBER-DANDI with your GitHub account</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this authentication happen automatically or does it (like DANDI) require admin approval for new registrants? If the latter, perhaps this should be moved to the top as a pre-step (since there might be a temporal delay) as well as a mention to that extent (e.g., 'it may take up to X days for the account to be approved' or so)
|
Overall looks great - left my comments and impressions! |