Absence of Git vars is now properly reported

Author: aplteam

APLSource/Cider/Cider.dyalog

@@ -9,7 +9,11 @@
 
     ∇ r←Version;fully
       :Access Public Shared
-      r←'0.31.0-beta-5+410'
+      r←'0.31.1+410'
+      ⍝ * 0.31.1 ⋄ 2023-08-05
+      ⍝   * The function `GetCiderGlobalConfigHomeFolder` crashed when Cider was not properly installed
+      ⍝   * The absence of APLGit2 is now reported by OpenProject in case the project is managed by Git
+      ⍝   * Version 0.30.0 wrongly pretended to be a beta release when it wasn't
       ⍝ * 0.31.0 ⋄ 2023-08-04
       ⍝   * Step added to `OpenProject`: checks for a non-empty variable `ToDo` in the root of the project now
       ⍝   * When Cider is asked for "Make" it checks for a variable `ToDo` now and reports its findings
@@ -556,6 +560,8 @@
                   dmx←⎕DMX
                   :If 127=dmx.EN
                       p'The project appears to be managed by Git but Git is not installed?!'
+                  :ElseIf 128=dmx.EN
+                      p'The project appears to be managed by Git but user.email and/or user.name are not defined'
                   :ElseIf 0<≢dmx.Message
                       ⎕←'The Git status of the project could not be determined due to an error:'
                       ⎕←dmx.Message,'; rc=',⍕dmx.EN
@@ -575,6 +581,8 @@
                   p'The project appears to be managed by Git but the user command ]APLGit2 and'
                   p'it''s API are missing, therefore no information can be provided regarding Git'
               :EndIf
+          :Else
+              p'The project appears to be managed by Git, but the package "APLGit2" is not installed...'
           :EndIf
       :EndIf
     ∇
@@ -1169,8 +1177,10 @@
       :If 'Win'≡3↑##.APLTreeUtils2.GetOperatingSystem ⍬
       :AndIf ~⎕NEXISTS folder,'config.json'
           oldFolder←(2 ⎕NQ #'GetEnvironment' 'APPDATA'),'/.cider/'
-          res←folder∘{⍺(⎕NMOVE⍠('IfExists' 'Skip')##.FilesAndDirs.ExecNfunction)⍵}¨##.FilesAndDirs.ListFiles oldFolder
-          ##.FilesAndDirs.RmDir oldFolder
+          :If ⎕NEXISTS oldFolder
+              res←folder∘{⍺(⎕NMOVE⍠('IfExists' 'Skip')##.FilesAndDirs.ExecNfunction)⍵}¨##.FilesAndDirs.ListFiles oldFolder
+              ##.FilesAndDirs.RmDir oldFolder
+          :EndIf
       :EndIf
     ∇
 

APLSource/Cider_uc.dyalog

@@ -1,7 +1,7 @@
-:Class Cider_UC
+:Class Cider_UC
 ⍝ User Command class for the project manager "Cider"
 ⍝ Kai Jaeger
-⍝ 2023-08-02
+⍝ 2023-08-05
 
 
 
@@ -231,8 +231,9 @@
 
     ∇ r←ListAliases Args
       :If Args.edit
-          EditAliasFile ⍬
-          r←ProcessAliases 0 0 0
+          :If 0=≢r←EditAliasFile ⍬
+              r←ProcessAliases 0 0 0
+          :EndIf
       :Else
           r←ProcessAliases Args.(prune edit quiet)
       :EndIf
@@ -852,60 +853,63 @@
     ∇
 
     ∇ {r}←EditAliasFile dummy;filename;data_;Local;aliases;b;report;buff;b2;b3;flag;b4;b5;aliases_;b6
-      r←⍬
+      r←''
       filename←P.GetCiderAliasFilename
       :If ~⎕NEXISTS filename
           3 ⎕MKDIR 1⊃⎕NPARTS filename
           (⊂'')⎕NPUT filename
       :EndIf
       aliases_←P.GetAliasFileContent
-      aliases←⍕aliases_
-      aliases_←⊃¨{⍺,'=',⍵}/¨↓aliases_
-      :Repeat
-          ⎕ED'aliases'
-          aliases←{'⍝'∊⍵:⍵↑⍨¯1+⍵⍳'⍝' ⋄ ⍵}¨↓aliases   ⍝ Cider might inject comments to highlight problems, see below.
-          aliases←(aliases∨.≠¨' ')⌿aliases
-          aliases←{b←' '=⍵ ⋄ ⍵/⍨~(∧\b)∨(⌽∧\⌽b)∨'  '⍷⍵}¨aliases
-          aliases←{' '(≠⊆⊢)⍵}¨aliases
-          aliases←⊃¨{⍺,'=',⍵}/¨aliases
-          flag←0
-          :If aliases≢aliases_
-              aliases_/⍨←({⍵↑⍨¨⍵⍳¨'='}aliases_)∊{⍵↑⍨¨⍵⍳¨'='}aliases   ⍝ Get rid of deleted ones
-              report←(≢aliases)⍴⊂''
-              :If ∨/b←~1=aliases+.=¨'='
-                  (b/report)←⊂' ⍝ Does not carry exactly one "="'
-              :EndIf
-              buff←↑{'='(≠⊆⊢)⍵}¨(~b)/aliases
-              :If ∨/b2←~{∧/⍵∊⎕A,(⎕C ⎕A),⎕D,'-'}¨buff[;1]
-                  b3←(~b)\b2
-                  (b3/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'An alias must consist of nothing but A-Z, a-z, 0-9 and a hyphen'
-              :EndIf
-              :If ∨/b2←~⎕NEXISTS buff[;2]
-                  b3←(~b)\b2
-                  (b3/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'Folder does not exist'
-              :EndIf
-              :If ∨/b4←(~b2)\~⎕NEXISTS(~b2)/buff[;2],¨⊂'/cider.config'
-                  b5←(~b)\b4
-                  (b5/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'Folder does not contain a Cider config file'
-              :EndIf
-              :If {(≢⍵)>≢∪⍵}buff←{⍵↓⍨⍵⍳'='}¨aliases
-                  b6←~{(⍳≢⍵)=⍵⍳⍵}buff
-                  (b6/report)←⊂'⍝ Path has already an alias'
-              :EndIf
-              :If 0=≢∊report
-                  flag←1
+      :If 0<≢aliases←⍕aliases_
+          aliases_←⊃¨{⍺,'=',⍵}/¨↓aliases_
+          :Repeat
+              ⎕ED'aliases'
+              aliases←{'⍝'∊⍵:⍵↑⍨¯1+⍵⍳'⍝' ⋄ ⍵}¨↓aliases   ⍝ Cider might inject comments to highlight problems, see below.
+              aliases←(aliases∨.≠¨' ')⌿aliases
+              aliases←{b←' '=⍵ ⋄ ⍵/⍨~(∧\b)∨(⌽∧\⌽b)∨'  '⍷⍵}¨aliases
+              aliases←{' '(≠⊆⊢)⍵}¨aliases
+              aliases←⊃¨{⍺,'=',⍵}/¨aliases
+              flag←0
+              :If aliases≢aliases_
+                  aliases_/⍨←({⍵↑⍨¨⍵⍳¨'='}aliases_)∊{⍵↑⍨¨⍵⍳¨'='}aliases   ⍝ Get rid of deleted ones
+                  report←(≢aliases)⍴⊂''
+                  :If ∨/b←~1=aliases+.=¨'='
+                      (b/report)←⊂' ⍝ Does not carry exactly one "="'
+                  :EndIf
+                  buff←↑{'='(≠⊆⊢)⍵}¨(~b)/aliases
+                  :If ∨/b2←~{∧/⍵∊⎕A,(⎕C ⎕A),⎕D,'-'}¨buff[;1]
+                      b3←(~b)\b2
+                      (b3/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'An alias must consist of nothing but A-Z, a-z, 0-9 and a hyphen'
+                  :EndIf
+                  :If ∨/b2←~⎕NEXISTS buff[;2]
+                      b3←(~b)\b2
+                      (b3/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'Folder does not exist'
+                  :EndIf
+                  :If ∨/b4←(~b2)\~⎕NEXISTS(~b2)/buff[;2],¨⊂'/cider.config'
+                      b5←(~b)\b4
+                      (b5/report){'⍝'∊⍺:⍺,'; ',⍵ ⋄ ⍺,' ⍝ ',⍵}←⊂'Folder does not contain a Cider config file'
+                  :EndIf
+                  :If {(≢⍵)>≢∪⍵}buff←{⍵↓⍨⍵⍳'='}¨aliases
+                      b6←~{(⍳≢⍵)=⍵⍳⍵}buff
+                      (b6/report)←⊂'⍝ Path has already an alias'
+                  :EndIf
+                  :If 0=≢∊report
+                      flag←1
+                  :Else
+                      aliases←(1+⌈/≢¨aliases)↑¨aliases
+                      aliases←aliases{0=≢⍵:⍺ ⋄ ⍺,'⍝ ',⍵}¨report
+                  :EndIf
+                  :If ~flag
+                      aliases←⍕↑{'='(≠⊆⊢)⍵}¨aliases
+                  :EndIf
               :Else
-                  aliases←(1+⌈/≢¨aliases)↑¨aliases
-                  aliases←aliases{0=≢⍵:⍺ ⋄ ⍺,'⍝ ',⍵}¨report
-              :EndIf
-              :If ~flag
-                  aliases←⍕↑{'='(≠⊆⊢)⍵}¨aliases
+                  flag←1
               :EndIf
-          :Else
-              flag←1
-          :EndIf
-      :Until flag
-      (⊂aliases)⎕NPUT filename 1
+          :Until flag
+          (⊂aliases)⎕NPUT filename 1
+      :Else
+          r←'There are no aliases defined in ',filename
+      :EndIf
     ∇
 
     YesOrNo←{⍺←⊢ ⋄ ⍺ ⎕SE.Cider.##.CommTools.YesOrNo ⍵}

apl-package.json

@@ -19,5 +19,5 @@
   source: "APLSource/Cider/",
   tags: "project-management",
   userCommandScript: "APLSource/Cider_UC.dyalog",
-  version: "0.31.0+485",
+  version: "0.31.1+486",
 }