Merge pull request #178 from codefresh-io/fix-memory-leak

fix: fix memory leak if `timeout` is set

Author: apocas

lib/modem.js

@@ -283,17 +283,15 @@ Modem.prototype.buildRequest = function (options, context, data, callback) {
   if (self.connectionTimeout) {
     connectionTimeoutTimer = setTimeout(function () {
       debug('Connection Timeout of %s ms exceeded', self.connectionTimeout);
-      req.abort();
+      req.destroy();
     }, self.connectionTimeout);
   }
 
   if (self.timeout) {
-    req.on('socket', function (socket) {
-      socket.setTimeout(self.timeout);
-      socket.on('timeout', function () {
-        debug('Timeout of %s ms exceeded', self.timeout);
-        req.abort();
-      });
+    req.setTimeout(self.timeout);
+    req.on('timeout', function () {
+      debug('Timeout of %s ms exceeded', self.timeout);
+      req.destroy();
     });
   }
 

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "docker-modem",
   "description": "Docker remote API network layer module.",
-  "version": "5.0.3",
+  "version": "5.0.4",
   "author": "Pedro Dias <[email protected]>",
   "maintainers": [
     "apocas <[email protected]>"