Skip to content

Commit 80cccf8

Browse files
committed
fix a react iterator warning
1 parent 2d55e0f commit 80cccf8

File tree

2 files changed

+21
-8
lines changed

2 files changed

+21
-8
lines changed

app/components/Inspector/Inspector.js

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,12 @@ export default class Inspector extends React.Component {
133133
}
134134

135135
return (
136-
<div id={id} onClick={this.selectId.bind(this, id)} className={className}>{id}</div>
136+
<div
137+
id={id}
138+
key={`inspector-sidebar-item-${id}`}
139+
onClick={this.selectId.bind(this, id)}
140+
className={className}
141+
>{id}</div>
137142
);
138143
}
139144

@@ -311,11 +316,12 @@ class StoreTreeFieldSet extends React.Component {
311316
}
312317
}
313318

314-
const StoreTreeArray = ({ value }) => (
315-
<div className="store-tree-field-set">
319+
const StoreTreeArray = ({ value }) => {
320+
console.log(value);
321+
return (<div className="store-tree-field-set">
316322
{value.map((item, index) => <StoreTreeArrayItem item={item} index={index} /> )}
317-
</div>
318-
)
323+
</div>);
324+
}
319325

320326
const StoreTreeArrayItem = ({ item, index }) => (
321327
<div>
@@ -330,7 +336,7 @@ const StoreTreeArrayItem = ({ item, index }) => (
330336
const StoreTreeObject = ({ value, highlight, inArray }) => {
331337
if (isIdReference(value)) {
332338
return (
333-
<StoreTreeFieldSet dataId={value.id} inArray={inArray} />
339+
<StoreTreeFieldSet key={`storee-tree-field-set-${value.id}`} dataId={value.id} inArray={inArray} />
334340
)
335341
}
336342

extension/dist/index_bundle.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81441,7 +81441,12 @@
8144181441

8144281442
return _react2.default.createElement(
8144381443
'div',
81444-
{ id: id, onClick: this.selectId.bind(this, id), className: className },
81444+
{
81445+
id: id,
81446+
key: 'inspector-sidebar-item-' + id,
81447+
onClick: this.selectId.bind(this, id),
81448+
className: className
81449+
},
8144581450
id
8144681451
);
8144781452
}
@@ -81699,6 +81704,8 @@
8169981704

8170081705
var StoreTreeArray = function StoreTreeArray(_ref6) {
8170181706
var value = _ref6.value;
81707+
81708+
console.log(value);
8170281709
return _react2.default.createElement(
8170381710
'div',
8170481711
{ className: 'store-tree-field-set' },
@@ -81730,7 +81737,7 @@
8173081737
inArray = _ref8.inArray;
8173181738

8173281739
if (isIdReference(value)) {
81733-
return _react2.default.createElement(StoreTreeFieldSet, { dataId: value.id, inArray: inArray });
81740+
return _react2.default.createElement(StoreTreeFieldSet, { key: 'storee-tree-field-set-' + value.id, dataId: value.id, inArray: inArray });
8173481741
}
8173581742

8173681743
var className = '';

0 commit comments

Comments
 (0)