Skip to content

Commit 610f022

Browse files
jerelmillerjerelmiller
committed
Remove devtools.displayValue for now
1 parent ee9d89c commit 610f022

16 files changed

Lines changed: 0 additions & 269 deletions

File tree

‎.api-reports/api-report-cache.api.md‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ export namespace ApolloCache {
5757
}
5858
// (undocumented)
5959
export interface Scalar<TSerialized, TParsed> {
60-
// (undocumented)
61-
devtools: {
62-
displayValue: (parsedValue: TParsed) => unknown;
63-
};
6460
// (undocumented)
6561
is: IsLooselyEqual<TSerialized, TParsed> extends true ? (value: TSerialized | TParsed) => boolean : (value: TSerialized | TParsed) => value is TParsed;
6662
// (undocumented)
@@ -577,10 +573,6 @@ const _ignoreModifier: unique symbol;
577573
export namespace InMemoryCache {
578574
// (undocumented)
579575
export interface ScalarConfig<TSerialized, TParsed> {
580-
// (undocumented)
581-
devtools?: {
582-
displayValue?(value: TParsed): unknown;
583-
};
584576
// (undocumented)
585577
is?: IsLooselyEqual<TSerialized, TParsed> extends true ? {
586578
_(value: TSerialized | TParsed): boolean;

‎.api-reports/api-report.api.md‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ export namespace ApolloCache {
5151
}
5252
// (undocumented)
5353
export interface Scalar<TSerialized, TParsed> {
54-
// (undocumented)
55-
devtools: {
56-
displayValue: (parsedValue: TParsed) => unknown;
57-
};
5854
// Warning: (ae-forgotten-export) The symbol "IsLooselyEqual" needs to be exported by the entry point index.d.ts
5955
//
6056
// (undocumented)
@@ -1582,10 +1578,6 @@ type InferContextValueFromResolvers<TResolvers> = TResolvers extends {
15821578
export namespace InMemoryCache {
15831579
// (undocumented)
15841580
export interface ScalarConfig<TSerialized, TParsed> {
1585-
// (undocumented)
1586-
devtools?: {
1587-
displayValue?(value: TParsed): unknown;
1588-
};
15891581
// (undocumented)
15901582
is?: IsLooselyEqual<TSerialized, TParsed> extends true ? {
15911583
_(value: TSerialized | TParsed): boolean;

‎integration-tests/type-tests/customScalars/all-any/differentTypes/index.ts‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -191,33 +191,6 @@ test("is narrows to the parsed type when used as a type guard", () => {
191191
}
192192
});
193193

194-
test("devtools.displayValue receives the parsed type", () => {
195-
new InMemoryCache({
196-
scalars: {
197-
DateTime: {
198-
serialize: (value) => value.toISOString(),
199-
parse: (value) => new Date(value),
200-
devtools: {
201-
displayValue: (value) => {
202-
expectTypeOf(value).toEqualTypeOf<Date>();
203-
return value.toISOString();
204-
},
205-
},
206-
},
207-
Unknown: {
208-
serialize: (value) => value,
209-
parse: (value) => value,
210-
devtools: {
211-
displayValue: (value) => {
212-
expectTypeOf(value).toEqualTypeOf<any>();
213-
return value.length;
214-
},
215-
},
216-
},
217-
},
218-
});
219-
});
220-
221194
test("InMemoryCache.getScalar returns the resolved scalar for a declared scalar", () => {
222195
const cache = new InMemoryCache({
223196
scalars: {

‎integration-tests/type-tests/customScalars/all-any/empty/index.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,23 +137,6 @@ test("is receives the combined serialized and parsed type", () => {
137137
});
138138
});
139139

140-
test("devtools.displayValue receives the parsed type", () => {
141-
new InMemoryCache({
142-
scalars: {
143-
RelativeDate: {
144-
serialize: (value) => value,
145-
parse: (value) => value,
146-
devtools: {
147-
displayValue: (value) => {
148-
expectTypeOf(value).toEqualTypeOf<any>();
149-
return value;
150-
},
151-
},
152-
},
153-
},
154-
});
155-
});
156-
157140
test("getScalar returns the resolved scalar or undefined", () => {
158141
const cache = new InMemoryCache();
159142

‎integration-tests/type-tests/customScalars/all-any/matchingTypes/index.ts‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -213,33 +213,6 @@ test("is receives the combined serialized and parsed type", () => {
213213
});
214214
});
215215

216-
test("devtools.displayValue receives the parsed type", () => {
217-
new InMemoryCache({
218-
scalars: {
219-
RelativeDate: {
220-
serialize: (value) => value,
221-
parse: (value) => value,
222-
devtools: {
223-
displayValue: (value) => {
224-
expectTypeOf(value).toEqualTypeOf<string>();
225-
return value;
226-
},
227-
},
228-
},
229-
Unknown: {
230-
serialize: (value) => value,
231-
parse: (value) => value,
232-
devtools: {
233-
displayValue: (value) => {
234-
expectTypeOf(value).toEqualTypeOf<any>();
235-
return value;
236-
},
237-
},
238-
},
239-
},
240-
});
241-
});
242-
243216
test("getScalar returns the resolved scalar or undefined", () => {
244217
const cache = new InMemoryCache();
245218

‎integration-tests/type-tests/customScalars/all-structured/empty/index.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -139,23 +139,6 @@ test("is receives the combined serialized and parsed type", () => {
139139
});
140140
});
141141

142-
test("devtools.displayValue receives the parsed type", () => {
143-
new InMemoryCache({
144-
scalars: {
145-
Unknown: {
146-
serialize: (value) => value,
147-
parse: (value) => value,
148-
devtools: {
149-
displayValue: (value) => {
150-
expectTypeOf(value).toEqualTypeOf<string>();
151-
return value;
152-
},
153-
},
154-
},
155-
},
156-
});
157-
});
158-
159142
test("getScalar returns the resolved scalar or undefined", () => {
160143
const cache = new InMemoryCache();
161144

‎integration-tests/type-tests/customScalars/all-unknown/differentTypes/index.ts‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -192,33 +192,6 @@ test("is narrows to the parsed type when used as a type guard", () => {
192192
}
193193
});
194194

195-
test("devtools.displayValue receives the parsed type", () => {
196-
new InMemoryCache({
197-
scalars: {
198-
DateTime: {
199-
serialize: (value) => value.toISOString(),
200-
parse: (value) => new Date(value),
201-
devtools: {
202-
displayValue: (value) => {
203-
expectTypeOf(value).toEqualTypeOf<Date>();
204-
return value.toISOString();
205-
},
206-
},
207-
},
208-
Unknown: {
209-
serialize: (value) => value,
210-
parse: (value) => value,
211-
devtools: {
212-
displayValue: (value) => {
213-
expectTypeOf(value).toEqualTypeOf<unknown>();
214-
return value;
215-
},
216-
},
217-
},
218-
},
219-
});
220-
});
221-
222195
test("InMemoryCache.getScalar returns the resolved scalar for a declared scalar", () => {
223196
const cache = new InMemoryCache({
224197
scalars: {

‎integration-tests/type-tests/customScalars/all-unknown/empty/index.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -141,23 +141,6 @@ test("is receives the combined serialized and parsed type", () => {
141141
});
142142
});
143143

144-
test("devtools.displayValue receives the parsed type", () => {
145-
new InMemoryCache({
146-
scalars: {
147-
RelativeDate: {
148-
serialize: (value) => value,
149-
parse: (value) => value,
150-
devtools: {
151-
displayValue: (value) => {
152-
expectTypeOf(value).toEqualTypeOf<unknown>();
153-
return value;
154-
},
155-
},
156-
},
157-
},
158-
});
159-
});
160-
161144
test("getScalar returns the resolved scalar or undefined", () => {
162145
const cache = new InMemoryCache();
163146

‎integration-tests/type-tests/customScalars/all-unknown/matchingTypes/index.ts‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -215,33 +215,6 @@ test("is receives the combined serialized and parsed type", () => {
215215
});
216216
});
217217

218-
test("devtools.displayValue receives the parsed type", () => {
219-
new InMemoryCache({
220-
scalars: {
221-
RelativeDate: {
222-
serialize: (value) => value,
223-
parse: (value) => value,
224-
devtools: {
225-
displayValue: (value) => {
226-
expectTypeOf(value).toEqualTypeOf<string>();
227-
return value;
228-
},
229-
},
230-
},
231-
Unknown: {
232-
serialize: (value) => value,
233-
parse: (value) => value,
234-
devtools: {
235-
displayValue: (value) => {
236-
expectTypeOf(value).toEqualTypeOf<unknown>();
237-
return value;
238-
},
239-
},
240-
},
241-
},
242-
});
243-
});
244-
245218
test("getScalar returns the resolved scalar or undefined", () => {
246219
const cache = new InMemoryCache();
247220

‎integration-tests/type-tests/customScalars/differentTypes/index.ts‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -156,23 +156,6 @@ test("is narrows to the parsed type when used as a type guard", () => {
156156
}
157157
});
158158

159-
test("devtools.displayValue receives the parsed type", () => {
160-
new InMemoryCache({
161-
scalars: {
162-
DateTime: {
163-
serialize: (value) => value.toISOString(),
164-
parse: (value) => new Date(value),
165-
devtools: {
166-
displayValue: (value) => {
167-
expectTypeOf(value).toEqualTypeOf<Date>();
168-
return value.toISOString();
169-
},
170-
},
171-
},
172-
},
173-
});
174-
});
175-
176159
test("InMemoryCache.getScalar returns the resolved scalar for a declared scalar", () => {
177160
const cache = new InMemoryCache({
178161
scalars: {

0 commit comments

Comments
 (0)