Prevent setTimeout from firing if we can't match devtools user agent

Author: jerelmiller

src/core/ApolloClient.ts

@@ -1169,33 +1169,34 @@ export class ApolloClient {
      */
     if (!hasSuggestedDevtools && __DEV__) {
       hasSuggestedDevtools = true;
+
+      const ua = window.navigator.userAgent;
+      let url: string | undefined;
+
+      if (typeof ua === "string") {
+        if (ua.indexOf("Chrome/") > -1) {
+          url =
+            "https://chrome.google.com/webstore/detail/" +
+            "apollo-client-developer-t/jdkknkkbebbapilgoeccciglkfbmbnfm";
+        } else if (ua.indexOf("Firefox/") > -1) {
+          url =
+            "https://addons.mozilla.org/en-US/firefox/addon/apollo-developer-tools/";
+        }
+      }
+
       if (
         window.document &&
         window.top === window.self &&
-        /^(https?|file):$/.test(window.location.protocol)
+        /^(https?|file):$/.test(window.location.protocol) &&
+        url
       ) {
         setTimeout(() => {
           if (!(window as any).__APOLLO_DEVTOOLS_GLOBAL_HOOK__) {
-            const nav = window.navigator;
-            const ua = nav && nav.userAgent;
-            let url: string | undefined;
-            if (typeof ua === "string") {
-              if (ua.indexOf("Chrome/") > -1) {
-                url =
-                  "https://chrome.google.com/webstore/detail/" +
-                  "apollo-client-developer-t/jdkknkkbebbapilgoeccciglkfbmbnfm";
-              } else if (ua.indexOf("Firefox/") > -1) {
-                url =
-                  "https://addons.mozilla.org/en-US/firefox/addon/apollo-developer-tools/";
-              }
-            }
-            if (url) {
-              invariant.log(
-                "Download the Apollo DevTools for a better development " +
-                  "experience: %s",
-                url
-              );
-            }
+            invariant.log(
+              "Download the Apollo DevTools for a better development " +
+                "experience: %s",
+              url
+            );
           }
         }, 10000);
       }