add a removals codemod - #12838
Conversation
🦋 Changeset detectedLatest commit: 898d51f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
size-limit report 📦
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 26 new, 66 changed, 5 removedBuild ID: 731b5e09c43e02ff1a5f0784 URL: https://www.apollographql.com/docs/deploy-preview/731b5e09c43e02ff1a5f0784 |
f9d37d0 to
6265da5
Compare
69f4806 to
56e2502
Compare
4c80e90 to
5944a3e
Compare
jerelmiller
left a comment
There was a problem hiding this comment.
Let's connect and bike shed on the entrypoint name, but I love this PR!
| "default": "./src/utilities/environment/index.ts" | ||
| } | ||
| }, | ||
| "./zz_removals": "./src/zz_removals.ts" |
There was a problem hiding this comment.
I love every part of this PR except this name 😆. What about something like v4-migration?
There was a problem hiding this comment.
Yeah I hate it too, I just wanted it to be alphabetically sorted to the end so users don't accidentally use it.
If we don't plan for entrypoints starting with w, x, y, or z, v4-migration sounds great!
| * docblocks will explain the removal and suggest alternatives. | ||
| */ | ||
|
|
||
| export declare namespace Removals { |
There was a problem hiding this comment.
Note for the upgrade guide: we will probably want to mention that any non-type exported from this entrypoint will cause runtime errors.
642973d to
898d51f
Compare
No description provided.