Skip to content

Ensure error argument to delay/attempts functions is an ErrorLike - #12824

Merged
jerelmiller merged 10 commits into
release-4.0from
jerel/pq-error-type
Aug 5, 2025
Merged

Ensure error argument to delay/attempts functions is an ErrorLike#12824
jerelmiller merged 10 commits into
release-4.0from
jerel/pq-error-type

Conversation

@jerelmiller

@jerelmiller jerelmiller commented Aug 4, 2025

Copy link
Copy Markdown
Member

No description provided.

@jerelmiller
jerelmiller requested a review from phryneas August 4, 2025 22:26
@changeset-bot

changeset-bot Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3bb9f56

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown 
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12824

commit: 3bb9f56

@apollo-librarian

apollo-librarian Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 005363e2415fc9bad428a295
Build Logs: View logs

phryneas
phryneas reviewed Aug 5, 2025
View reviewed changes
Comment thread src/link/retry/retryLink.ts
return;
}

this.observer.error(error);

@phryneas phryneas Aug 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood catch!

@github-actions github-actions Bot added the auto-cleanup 🤖 label Aug 5, 2025
@jerelmiller
jerelmiller force-pushed the jerel/pq-error-type branch from bde09a5 to da57474 Compare August 5, 2025 15:33
Base automatically changed from jerel/more-unify-types to release-4.0 August 5, 2025 16:02
@jerelmiller
jerelmiller force-pushed the jerel/pq-error-type branch from da57474 to 3bb9f56 Compare August 5, 2025 16:03
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 42.77 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.72 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.76 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 26.92 KB (0%)
import { ApolloProvider } from "@apollo/client/react" 5.9 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 971 B (0%)
import { useQuery } from "@apollo/client/react" 7.21 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 2.23 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 7.1 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production) 2.13 KB (0%)
import { useMutation } from "@apollo/client/react" 6.45 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 1.48 KB (0%)
import { useSubscription } from "@apollo/client/react" 6.78 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 1.8 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 8.58 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.63 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 8.33 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.38 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 8.28 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.36 KB (0%)
import { useReadQuery } from "@apollo/client/react" 6.59 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 1.63 KB (0%)
import { useFragment } from "@apollo/client/react" 6.65 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 1.69 KB (0%)

@jerelmiller
jerelmiller merged commit 0506f12 into release-4.0 Aug 5, 2025
44 checks passed
@jerelmiller
jerelmiller deleted the jerel/pq-error-type branch August 5, 2025 16:11
@github-actions github-actions Bot mentioned this pull request Aug 5, 2025
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@phryneas phryneas phryneas approved these changes

Assignees

No one assigned

Labels

auto-cleanup 🤖

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerelmiller @phryneas