Skip to content

update knip action node version - #13244

Merged
phryneas merged 1 commit into
mainfrom
pr/update-knip-node
May 27, 2026
Merged

update knip action node version#13244
phryneas merged 1 commit into
mainfrom
pr/update-knip-node

Conversation

@phryneas

@phryneas phryneas commented May 27, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build system configuration to use Node.js 24.

Review Change Stack

@apollo-librarian

apollo-librarian Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 0e77f67b417460e7cd61a4d6
Build Logs: View logs

✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@changeset-bot

changeset-bot Bot commented May 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5d0e736

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 66d51f7b-6a3b-4c1b-8f64-d87806e4c5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 414f927 and 5d0e736.

📒 Files selected for processing (1)
  • .github/workflows/knip.yml
📝 Walkthrough

Walkthrough

The Node.js runtime version used by the knip linting workflow is updated from version 20.x to version 24.x. This single-file configuration change affects the jobs.lint workflow step that runs the static analysis check.

Changes

Node.js Runtime Update

Layer / File(s) Summary
Node.js 24 upgrade for knip workflow
.github/workflows/knip.yml		 The actions/setup-node step in the lint job is configured to use Node.js 24.x instead of 20.x.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump, so small and neat,
From twenty to twenty-four, the upgrade's complete!
Node.js runs faster, the knip checks run strong,
CI workflows dance along, nothing goes wrong.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'update knip action node version' directly and clearly describes the main change: updating the Node.js version in the knip GitHub Actions workflow from 20.x to 24.x.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phryneas
phryneas enabled auto-merge (squash) May 27, 2026 13:48
@pkg-pr-new

pkg-pr-new Bot commented May 27, 2026

Copy link
Copy Markdown 
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@13244

commit: 5d0e736

@phryneas
phryneas merged commit fc379af into main May 27, 2026
47 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 27, 2026
Merged
@jerelmiller
jerelmiller deleted the pr/update-knip-node branch May 29, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phryneas