How to resolve generated mock arguments when names clash?

[drekka]

Question

I'm trying to figure out an issue with a unit test in Swift where I need to generate a mock response. I've been looking at the generated Query type which has a huge list of initializer arguments sourced from all the available queries in the *.grapql files.

The problem I've encountered in that there are two queries which have the same names in them, but different types. So something like this:

query A {
  someThing: TypeA {
  }
}


query B {
  someThing: TypeB {
  }
}

This generates a Query initializer that looks like this:

public extension Mock where O == Query {
  convenience init(
    someThing: Mock< TypeB >? = nil
) { … }

Which is a problem because I cannot use this initializer with a TypeA argument.

My question is how do I resolve this? Should these names be unique across the entire set of queries? or is there some other way to set things up?

[calvincestari]

Hi @drekka - you'll need to share a schema + operation that closer resembles what you're working with. The query A and B example you have above would need a schema like this, which I don't think is valid GraphQL.

type Query {
  someThing: TypeA
  someThing: TypeB
}

Either that or a sample project that passes schema + operation validation and produces the test mock output you're describing.

[drekka]

Sorry guys, I'm not an expert and I was trying to distill the problem down from a huge graphQL setup and my Apollo knowledge is 'basic'.

From what I could see, the situation was that after reading the schema the code generating the mock was trying to deal with two arguments with the same name, but different types. And as we can't have duplicate argument names, it was keeping the argument with the first type and dropping the second. Which basically meant the mock was unusable for people needing the second type.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.