Error building generated library with release configuration

[jmccance]

Summary

Building the generated schema module in the release configuration when mocks are enabled results in a build error due to the addition of @testable imports.

Version

1.25.0

Steps to reproduce the behavior

1. Clone https://github.com/jmccance/apollo-ios-3595
2. cd RocketResolverAPI
3. Try building it with swift build -c release

Logs

[1/1] Planning build
Building for production...
/Users/jmccance/tmp/apollo-ios-odyssey/final/RocketReserverAPI/RocketReserverAPITestMocks/Launch+Mock.graphql.swift:5:18: error: module 'RocketReserverAPI' was not compiled for testing
 3 |
 4 | import ApolloTestSupport
 5 | @testable import RocketReserverAPI
   |                  `- error: module 'RocketReserverAPI' was not compiled for testing
 6 |
 7 | public class Launch: MockObject {

Anything else?

No response

[AnthonyMDev]

This looks like an issue with building the test mocks, not the actual schema module. I think you are configuring your project to include the test mocks in the schema module.

The test mocks are not intended for production use currently, so this behavior makes sense.
It's possible that we could resolve this by using an @_spi instead of @testable, but I'm not sure if we should be resolving this, because including the test mocks in production code should create an error.

Try moving your test mocks out to their own module. If the problem persists at that time, please let us know and we can reopen this issue!

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

[jmccance]

Hi @AnthonyMDev, thanks for getting back to me so quickly.

The test mocks are already in their own module, called "RocketReserverAPITestMocks" in the reproduction repository. You can see the Package.swift here, as generated by the codegen tool. The config for that can be found here. Is there a different way we should be configuring the codegen tool?

In our actual project, the app depends on the schema library but not the mocks library. We are not depending on the mocks anywhere in production code that I can tell. We hit the error when Xcode starts to build the app, compiles the upstream SPM dependencies, and errors out when it attempts to build the mock schema target. I haven't found a way to direct it to only build certain targets from the Apollo-generated package during this step, but am all ears if you know of one.

[jmccance]

@AnthonyMDev Argh, disregard please. I did some spelunking in our project and found a local package that pulled in a local package that pulled in our schema mocks. Since I wasn't able to reproduce the build failure in my test project in Xcode, I think you're analysis was correct.

Thanks again, and have a great day!