Edge issue with the new equatable/hashable algorithm

[JOyo246]

Summary

When a query has a named fragment and an inline fragment, the new equatable logic seems to break. Trying to track this down, and it looks like the error is that __selections is used for the equatable check, but __selections looks vastly different after adding in an additional inlineFragment.

Version

1.5.2

Steps to reproduce the behavior

Query: https://github.com/apollographql/apollo-ios-dev/blob/main/Sources/StarWarsAPI/starwars-graphql/HeroDetails.graphql + add in an inline fragment of your choice.

query HeroDetailsWithFragment($episode: Episode) {
  hero(episode: $episode) {
    ...HeroDetails
    ... on Human {
      mass
    }
  }
}

After generating, notice your diff changes from __mergedSources to __selections, where the new inline fragment's field is the only selection.

Now, when creating this object, the only field used for hashable/equatable is the field on the inlineFragment.

Logs

Anything else?

No response

[JOyo246]

Oops, those steps are not actually reproducing the issue. 🙃

query HumanDetails($id: ID!) {
  human(id: $id) {
    ...HumanFriendData
    friends {
      ... on Droid {
        primaryFunction
      }
    }
  }
    
}

fragment HumanFriendData on Human {
  friends {
    name
  }
}

  func testStarWars() {
    
    let x = HumanDetailsQuery.Data.Human.Friend.AsDroid.init(name: "name1")
    
    let y = HumanDetailsQuery.Data.Human.Friend.AsDroid.init(name: "name2")
                                                                
    XCTAssertNotEqual(x, y)
  }

This query breaks equality/hashable though! Where the named fragment and inline fragment are querying the same field! (friends)

[AnthonyMDev]

Thanks so much for the reproduction case. I'm going to start looking into fixing this tomorrow, but I think I already have a strong suspicion of the cause.

[AnthonyMDev]

I've got a fix for this ready for Apollo iOS 2.0. I'm now working on back porting the fix to 1.x, which is going to take a bit more work. Should have this resolved this week.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

[AnthonyMDev]

Patch version with this fix is going out today for both Apollo iOS v1 & v2!