Build: always read the version from a single place (#6599)

Author: martinbonnin

.github/workflows/preview.yml

@@ -27,7 +27,6 @@ jobs:
       - run: |
           git clone --depth 1 --single-branch --branch ${{ inputs.branch }} https://github.com/$GITHUB_REPOSITORY
           cd apollo-kotlin
-          sed -i .old 's/VERSION_NAME=\([\.0-9]*\).*/VERSION_NAME=\1-${{ inputs.prerelease }}/g' gradle.properties
-          ./gradlew librarianPublishToGcs
+          LIBRARIAN_NIGHTLY ./gradlew librarianPublishToGcs
         env:
           LIBRARIAN_GOOGLE_SERVICES_JSON: ${{ secrets.APOLLO_KOTLIN_GOOGLE_SERVICES_JSON }}

build-logic/src/main/kotlin/Publishing.kt

@@ -151,7 +151,7 @@ fun Project.configureDokkaAggregate() {
 
   dokka.pluginsConfiguration.getByName("versioning") {
     this as DokkaVersioningPluginParameters
-    val currentVersion = findProperty("VERSION_NAME") as String
+    val currentVersion = version()
     version.set(currentVersion)
     olderVersionsDir.fileProvider(downloadKDocVersions.map { it.outputs.files.singleFile })
   }
@@ -187,15 +187,6 @@ private fun Project.configureModulePublishingInternal() {
     }
   }
 
-  tasks.withType(Jar::class.java) {
-    manifest {
-      attributes["Built-By"] = findProperty("POM_DEVELOPER_ID") as String?
-      attributes["Created-By"] = "Gradle ${gradle.gradleVersion}"
-      attributes["Implementation-Title"] = findProperty("POM_NAME") as String?
-      attributes["Implementation-Version"] = findProperty("VERSION_NAME") as String?
-    }
-  }
-
   extensions.configure(PublishingExtension::class.java) {
     publications {
       when {
@@ -342,12 +333,7 @@ private fun Project.configureModulePublishingInternal() {
  */
 private fun Project.setDefaultPomFields(mavenPublication: MavenPublication) {
   mavenPublication.groupId = findProperty("GROUP") as String?
-  var version = (findProperty("VERSION_NAME") as String?) ?: error("cannot find property 'VERSION_NAME'")
-  if (System.getenv("LIBRARIAN_RELEASE") == "true") {
-    // This is a release, drop the -SNAPSHOT
-    version = version.replace("-SNAPSHOT", "")
-  }
-  mavenPublication.version = version
+  mavenPublication.version = version()
 
   mavenPublication.pom {
     name.set(findProperty("POM_NAME") as String?)

build-logic/src/main/kotlin/api.kt

@@ -20,6 +20,10 @@ class KotlinCompilerOptions(
     val version: KotlinVersion = KotlinVersion.KOTLIN_2_0,
 )
 
+fun Project.version(): String {
+  return Librarian.version(property("VERSION_NAME")!!.toString())
+}
+
 fun Project.apolloLibrary(
     namespace: String,
     jvmTarget: Int? = null,
@@ -33,7 +37,7 @@ fun Project.apolloLibrary(
     kotlinCompilerOptions: KotlinCompilerOptions = KotlinCompilerOptions(),
 ) {
   group = property("GROUP")!!
-  version = property("VERSION_NAME")!!
+  version = version()
 
   if (androidOptions != null) {
     configureAndroid(namespace, androidOptions)

gradle/libraries.toml

@@ -187,8 +187,7 @@ androidx-test-runner = "androidx.test:runner:1.6.2"
 truth = { group = "com.google.truth", name = "truth", version.ref = "truth" }
 turbine = { group = "app.cash.turbine", name = "turbine", version = "1.1.0" }
 uuid = { group = "com.benasher44", name = "uuid", version = "0.8.2" }
-librarian = "com.gradleup.librarian:librarian-gradle-plugin:0.0.8-SNAPSHOT-30f5819e9747430b54e96ebb8d680e0fbe30f563"
-nmcp = "com.gradleup.nmcp:nmcp:0.2.2-SNAPSHOT-7db79adb17a2c6ae61fc00c89f6a6518ff458ed7"
+librarian = "com.gradleup.librarian:librarian-gradle-plugin:0.0.10-SNAPSHOT-ffba1a28eef796c5c91a33f609761618b0ef2e5e"
 slf4j-simple = "org.slf4j:slf4j-simple:2.0.13"
 slf4j-nop = "org.slf4j:slf4j-nop:2.0.13"
 licensee = "app.cash.licensee:licensee-gradle-plugin:1.12.0"