`ApolloTaskWithClasspath` is not cacheable if different Gradle log level options are used

[lwasyl]

Version

4.0.0

Summary

I know 4.0.0 is not the most recent release, but I think the issue is still there.

Here, Apollo plugin will construct options with the first enabled Gradle logger level:

apollo-kotlin/libraries/apollo-gradle-plugin-external/src/main/kotlin/com/apollographql/apollo/gradle/internal/DefaultApolloExtension.kt

Line 478 in a13fafd

LogLevel.entries.first { project.logger.isEnabled(it) },

Eventually here, this log level is a task input:

apollo-kotlin/libraries/apollo-gradle-plugin-external/src/main/kotlin/com/apollographql/apollo/gradle/internal/ApolloTaskWithClasspath.kt

Lines 28 to 29 in a13fafd

	@get:Input
	abstract val logLevel: Property<LogLevel>

I may be wrong but I don't think log level affects the task outputs, and as such shouldn't be an input to the task? The problem with current implementation is that ./gradlew <apolloGeneratingTask> and ./gradlew <apolloGeneratingTask> --quiet will not reuse the cache because task inputs have changed.

Steps to reproduce the behavior

No response

Logs

(Your logs here)

[martinbonnin]

Makes a lot of sense. Do you want to open a PR to remove the @get:Input? I'm not sure why it was there in the first place. Probably a bad copy/paste.

[lwasyl]

Sure 👍 Just removing the property is fine, there's no @NotAnInput annotation in Gradle or anything like that?

[lwasyl]

I think it should be @Internal, quick google tells me that otherwise Gradle complains at some point. Opened #6399

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.

[martinbonnin]

it should be @Internal

100%! Thanks for catching this and fixing it 💙