Skip to content

Default value validation is a breaking change, do it again in compiler 2.0 #928

Open
@SimonSapin

Description

@SimonSapin

PR #925 includes a change to start validating the default value of input fields and arguments. This turns out to break enough existing schemas (Router rejects them as invalid where it previously accepted them) that we consider it a breaking change. After some discussion, our plan is:

  1. Revert default value validation for now
  2. Publish a new compiler beta without it to unblock current work
  3. Finish up compiler 1.0 stable and use it in Router before its 1.x LTS
  4. Stricter validation, which we consider a breaking change, will be in compiler 2.0which will be used by router 2.0. This is the part tracked by this issue
  5. If needed later, we can backport LTS fixes to compiler 1.x

Metadata

Metadata

Assignees

No one assigned

    Labels

    apollo-compilerissues/PRs pertaining to semantic analysis & validationapollo-compiler-2.0Potential breaking API changes

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions