KeyvAdapter v5 type support

[reggermont]

Related to #457

TypeScript returns the following error:

Argument of type 'Keyv' is not assignable to parameter of type 'Keyv<string, Record<string, unknown>>'.
  Type 'Keyv' is missing the following properties from type 'Keyv<string, Record<string, unknown>>': once, getMaxListeners, rawListeners, listenerCount, and 3 more.ts(2345)

[kdybicz]

got blocked by same issue

[sebastiancretu]

here too

[simonjamois]

same here with this issue

[jaredwray]

Are you all still seeing this? If so, can I get an example so that we can get this fixed? Make sure you are at the latest as we added in additional support recently.

[simonjamois]

Sure !
I am in a strapi v5 configuration, where the graphql plugin is used, here are the specs :

import { KeyvAdapter } from "@apollo/utils.keyvadapter";
import { ErrorsAreMissesCache} from "@apollo/utils.keyvaluecache";
import Keyv from 'keyv';

export default ({ env }) => ({
  graphql: {
    config: {
      endpoint: "/graphql",
      shadowCRUD: true,
      playgroundAlways: true,
      depthLimit: 20,
      amountLimit: 100,
      defaultLimit: 10,
      maxLimit: 200,
//highlight begin
      apolloServer: {
        tracing: true,
        introspection: true,
        cache: 
        new ErrorsAreMissesCache(
          new KeyvAdapter(
          new Keyv(env("REDIS_URL"),{
            namespace:'apollo-cache',
            ttl: 3600 * 1000 //1 hour TTL
          })
            )
          ) 
//highlight end

Where typescript says : Argument of type 'Keyv<any>' is not assignable to parameter of type 'Keyv<string, Record<string, unknown>>'. Type 'Keyv<any>' is missing the following properties from type 'Keyv<string, Record<string, unknown>>': getMaxListeners, rawListeners, listenerCount, prependListener, and 2 more.

Versions are : keyv@5.1.2 @keyv/redis@3.0.1 @apollo/utils.keyvadapter@3.1.0 @apollo/utils.keyvaluecache3.1.0

[jaredwray]

@simonjamois - thanks and we are looking into this.

[chrisllontop]

@simonjamois Do you have a repo where I can check out the error? I tried to reproduce it but couldn’t.

[simonjamois]

The error seems fixed !
Just needed to update @apollo/utils.keyvadapter@3.1.0 > @4.0.0 to allow the module to sync with keyv@5.1.2
Thanks a lot ;)

[Cajuteq]

Hi, not entirely sure it is the exact same issue, but using

"@apollo/utils.keyvadapter": "^4.0.0",
"keyv": "^5.2.1",
"@keyv/redis": "^4.0.1",

I got

Argument of type 'Keyv<any>' is not assignable to parameter of type 'Keyv<string>'.
Types have separate declarations of a private property '_ttl'.

falling back to
"keyv": "5.1.2",
solved the issue, (I didn't tried other versions)

EDIT: the problem did not reappear after merging and bumping keyv up to 5.2.1 so I think the problem may be linked to other apollo settings as well and not that easy to reproduce; types are now Keyv<any>

[jaredwray]

@chrisllontop ☝️

[slagiewka]

I'm also struggling to figure out which versions to combine in order to have no _ttl issue there.
My setup follows docs:

  const adapter = new KeyvAdapter(new Keyv({store: new KeyvRedis(cluster)}), {disableBatchReads: true});