Skip to content

Commit ee018a7

Browse files
Update http-cache-semantics package (#159)
Update `http-cache-semantics` package to latest patch, resolving a security issue. Unlike many security updates Apollo repos receive, this is an _actual_ (non-dev) dependency of this package which means it is actually a user-facing security issue. The potential impact of this issue is limited to a DOS attack (via an inefficient regex). This security issue would only affect you if either: * you pass untrusted (i.e. from your users) `cache-control` request headers * you sending requests to untrusted REST server that might return malicious `cache-control` headers Since `http-cache-semantics` is a careted (^) dependency in this package, the security issue can (and might already) be resolved via a `package-lock.json` update within your project (possibly triggered by `npm audit` or another dependency update which has already updated its version of the package in question). If `npm ls http-cache-semantics` reveals a tree of dependencies which only include the `4.1.1` version (and no references to any previous versions) then you are currently unaffected and this patch should have (for all intents and purpose) no effect. More details available here: GHSA-rc47-6667-2j5j
1 parent 786c44f commit ee018a7

File tree

3 files changed

+37
-8
lines changed

3 files changed

+37
-8
lines changed

.changeset/five-snails-stare.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
'@apollo/datasource-rest': patch
3+
---
4+
5+
Update `http-cache-semantics` package to latest patch, resolving a security
6+
issue.
7+
8+
Unlike many security updates Apollo repos receive, this is an _actual_ (non-dev)
9+
dependency of this package which means it is actually a user-facing security
10+
issue.
11+
12+
The potential impact of this issue is limited to a DOS attack (via an
13+
inefficient regex).
14+
15+
This security issue would only affect you if either:
16+
* you pass untrusted (i.e. from your users) `cache-control` request headers
17+
* you sending requests to untrusted REST server that might return malicious
18+
`cache-control` headers
19+
20+
Since `http-cache-semantics` is a careted (^) dependency in this package, the
21+
security issue can (and might already) be resolved via a `package-lock.json`
22+
update within your project (possibly triggered by `npm audit` or another
23+
dependency update which has already updated its version of the package in
24+
question). If `npm ls http-cache-semantics` reveals a tree of dependencies which
25+
only include the `4.1.1` version (and no references to any previous versions)
26+
then you are currently unaffected and this patch should have (for all intents
27+
and purpose) no effect.
28+
29+
More details available here: https://github.com/advisories/GHSA-rc47-6667-2j5j

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@apollo/utils.keyvaluecache": "^2.0.0",
5353
"@apollo/utils.withrequired": "^2.0.0",
5454
"@types/http-cache-semantics": "^4.0.1",
55-
"http-cache-semantics": "^4.1.0",
55+
"http-cache-semantics": "^4.1.1",
5656
"lodash.isplainobject": "^4.0.6",
5757
"node-fetch": "^2.6.7"
5858
},

0 commit comments

Comments
 (0)