Skip to content

Update apollo.config.json with npm postinstall #2668

@LongLiveCHIEF

Description

@LongLiveCHIEF

Description

The rover npm package's postinstall script for npm could detect the presence of a apollo.config.json file in the package rover is being installed to, and either:

  • report into terminal that apollo.config.json was found, and if desired the bin path for the rover config should be updated to node_modules/@apollo/rover/binary/rover-<version>
  • prompt the user interactively if they'd like to update the apollo.config.json:rover.bin
  • just automatically overwrite the apollo.config.json:rover.bin

There is a possibility here that the rover config file proposal (#2047 ) could have a setting to define the desired behavior at a project level with a syncApolloConfig: true option.

Without this feature, users who don't install rover globally, but prefer to manage it as a npm package dependency can have a difficult time getting the path of the rover binary. (They don't all know to look in node_modules/@apollo/rover/bin)

An alternative to this feature would be for the vscode ide extension to look in the node_modules/@apollo/rover/bin folder automatically in addition to looking for the rover binary on the users PATH.

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature 🎉new commands, flags, functionality, and improved error messagestriageissues and PRs that need to be triaged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions