PRO-8130: default node parseHTML now detects whether an element has the relevant class, or lack of one, before classifying it as a default node (#5017)

Author: boutell

CHANGELOG.md

@@ -17,7 +17,7 @@
 * Let the `@apostrophecms/page:unpark` task unpark all parked pages with the given slug, not just the first one.
 * Exclude unknown page types from the page manager.
 * Resolved an issue affecting `withRelationships` with two or more steps. This issue could cause a document to appear to be related to the same document more than once.
-
+* Fixed a regression that prevented multiple variations of `p` with different classes from being recognized again when reopening the rich text editor, even if they are all on the style menu. This was caused by knock-on effects of upstream changes in tiptap and prosemirror and our previous efforts to mitigate these. Those upstream changes were correct, but they did have certain side effects in ApostropheCMS. By more fully specifying the desired behavior, we have now fully corrected the issue at the ApostropheCMS level.
 
 ### Security
 

modules/@apostrophecms/rich-text-widget/ui/apos/tiptap-extensions/Default.js

@@ -44,6 +44,27 @@ export default (options) => {
           HTMLAttributes: attrs,
           levels: def.options.level ? [ def.options.level ] : null
         };
+      },
+      parseHTML() {
+        return [
+          {
+            tag: 'p',
+            getAttrs: el => {
+              // We must make sure the DefaultNode is only
+              // returned for the subset of elements that actually
+              // match its class, or lack of one. Otherwise it will
+              // hoover up all elements sharing its element name,
+              // breaking the ability to have alternates with classes
+              // listed in "styles" in the toolbar "stick" when you
+              // open the editor again -Tom
+              if (def.options.class) {
+                return el.getAttribute('class') === def.options.class;
+              } else {
+                return !el.hasAttribute('class');
+              }
+            }
+          }
+        ];
       }
     });
   }