wip run postprocess on widget data update, tries to compare new and old relationships

Author: ValJed

modules/@apostrophecms/modal/ui/apos/composables/AposEditor.js

@@ -1,16 +1,21 @@
+import { isEqual } from 'lodash';
 // For now just moving postprocess logic here,
 // if needed we might move more from AposEditorMixin.js
 
 // Perform any postprocessing required by direct or nested schema fields
 // before the object can be saved
-export async function _postprocess(schema, data, widgetOptions) {
+export async function _postprocess(schema, data, widgetOptions, oldData) {
   // Relationship fields may have postprocessors (e.g. autocropping)
-  const relationships = findRelationships(schema, data);
+  const [ relationships, oldRelationships ] = findRelationships(schema, data, oldData);
 
-  for (const relationship of relationships) {
+  for (const [ i, relationship ] of relationships.entries()) {
+    const oldRelationship = oldRelationships[i];
     if (!(relationship.value && relationship.field.postprocessor)) {
       continue;
     }
+    if (checkSameRelationships(relationship.value, oldRelationship)) {
+      continue;
+    }
     const withType = relationship.field.withType;
     const mod = apos.modules[withType];
     const response = await apos.http.post(`${mod.action}/${relationship.field.postprocessor}`, {
@@ -30,15 +35,19 @@ export async function _postprocess(schema, data, widgetOptions) {
   }
 }
 
-function findRelationships(schema, object) {
+function findRelationships(schema, object, oldObject) {
   let relationships = [];
+  const oldRelationships = [];
   for (const field of schema) {
     if (field.type === 'relationship') {
       relationships.push({
         context: object,
         field,
         value: object[field.name]
       });
+      if (oldObject) {
+        oldRelationships.push(oldObject[field.name]);
+      }
     } else if (field.type === 'array') {
       for (const value of (object[field.name] || [])) {
         relationships = [
@@ -53,5 +62,20 @@ function findRelationships(schema, object) {
       ];
     }
   }
-  return relationships;
+  return [ relationships, oldRelationships ];
+}
+
+function checkSameRelationships(relationship, oldRelationship) {
+  for (const piece of relationship) {
+    const oldPiece = oldRelationship.find((p) => p._id === piece._id);
+    console.log('piece', piece);
+    console.log('oldPiece', oldPiece);
+    if (!oldPiece) {
+      return false;
+    }
+    if (!isEqual(piece._fields, oldPiece._fields)) {
+      return false;
+    }
+  }
+  return true;
 }

modules/@apostrophecms/modal/ui/apos/mixins/AposEditorMixin.js

@@ -220,11 +220,12 @@ export default {
         this.triggerValidation = false;
       });
     },
-    async postprocess() {
+    async postprocess(oldData) {
       await _postprocess(
         this.schema,
         this.docFields.data,
-        apos.area.widgetOptions[0]
+        apos.area.widgetOptions[0],
+        oldData
       );
     }
   }

modules/@apostrophecms/widget-type/ui/apos/components/AposWidgetEditor.vue

@@ -229,14 +229,22 @@ export default {
     this.initPreview();
   },
   methods: {
-    updateDocFields(value) {
+    async updateDocFields(value) {
       this.updateFieldErrors(value.fieldState);
+      const oldDocFields = klona(this.docFields.data);
       this.docFields.data = {
         ...this.docFields.data,
         ...value.data
       };
       this.evaluateConditions();
       this.updatePreview();
+      try {
+        await this.postprocess(oldDocFields);
+      } catch (e) {
+        await this.handleSaveError(e, {
+          fallback: 'An error occurred updating the widget.'
+        });
+      }
     },
     initPreview() {
       if (!this.preview) {
@@ -302,15 +310,6 @@ export default {
             return;
           }
         }
-        try {
-          await this.postprocess();
-        } catch (e) {
-          await this.handleSaveError(e, {
-            fallback: 'An error occurred saving the widget.'
-          });
-          return;
-        }
-
         const widget = this.getWidgetObject();
         this.saving = true;
         this.$emit('modal-result', widget);