Skip to content

Hide rich text controls on interaction - #5008

Merged
stuartromanek merged 12 commits into
mainfrom
pro-8045-hide-rt-controls
Jul 24, 2025
Merged

Hide rich text controls on interaction#5008
stuartromanek merged 12 commits into
mainfrom
pro-8045-hide-rt-controls

Conversation

@stuartromanek

Copy link
Copy Markdown
Member

Summary

  • Adds an event contextual widgets can emit that will signal to the widget wrapper to hide the widget controls
  • Rich text signals to hide widget controls on typing
  • Rich text signals to hide widget controls on text selection

@linear

linear Bot commented Jul 16, 2025

Copy link
Copy Markdown

@stuartromanek
stuartromanek requested review from ValJed and haroun July 16, 2025 17:59
@stuartromanek
stuartromanek requested a review from myovchev July 17, 2025 13:28

@boutell boutell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A protocol that allows any in-context widget editor to achieve this! I am excite

@BoDonkey should cover this in our custom in-context widget editor documentation

myovchev
myovchev previously approved these changes Jul 21, 2025

@myovchev myovchev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit! I'll do the automated testing asap.

haroun
haroun previously approved these changes Jul 23, 2025
@stuartromanek
stuartromanek dismissed stale reviews from haroun and myovchev via 925f0ab July 23, 2025 13:31
@stuartromanek
stuartromanek requested a review from myovchev July 23, 2025 13:51
@stuartromanek
stuartromanek merged commit de6b323 into main Jul 24, 2025
9 checks passed
@stuartromanek
stuartromanek deleted the pro-8045-hide-rt-controls branch July 24, 2025 12:59
haroun added a commit that referenced this pull request Jul 30, 2025
* main:
  Resolved an issue affecting `withRelationships` with two or more steps. This issue could cause a document to appear to be related to the same document more than on (#5015)
  thanks! (#5014)
  Fix #4979: Replace connect-multiparty with multer to resolve security vulnerability (#5013)
  Hide rich text controls on interaction (#5008)
haroun added a commit that referenced this pull request Jul 31, 2025
* main:
  PRO-8130: default node parseHTML now detects whether an element has the relevant class, or lack of one, before classifying it as a default node (#5017)
  Add regression tests for duplicate relationships resolution in some edge cases (#5016)
  Resolved an issue affecting `withRelationships` with two or more steps. This issue could cause a document to appear to be related to the same document more than on (#5015)
  thanks! (#5014)
  Fix #4979: Replace connect-multiparty with multer to resolve security vulnerability (#5013)
  Hide rich text controls on interaction (#5008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants