DVO-205: (chore) replace golint (#321)

Ricardo Lüders · web-flow · commit d7f475e51392 · 2024-04-19T12:24:07.000Z
* chore: replace golint with revive

* style: fix revive reports
diff --git a/.golangci.yml b/.golangci.yml
@@ -6,7 +6,7 @@ linters:
   enable:
   - gofmt
   - goimports
-  - golint
+  - revive
   - govet
   - misspell
   - unused
@@ -18,10 +18,6 @@ linters:
   - staticcheck
 
 linters-settings:
-  golint:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0
-
   lll:
     line-length: 120
     tab-width: 8
diff --git a/internal/testing/client.go b/internal/testing/client.go
@@ -27,7 +27,7 @@ func (c *TestClient) Create(ctx context.Context, obj client.Object, opts ...Requ
 	}
 }
 
-func (c *TestClient) Update(ctx context.Context, obj client.Object, opts ...RequestOption) {
+func (c *TestClient) Update(ctx context.Context, obj client.Object, _ ...RequestOption) {
 	gomega.ExpectWithOffset(1, c.client.Update(ctx, obj)).Should(gomega.Succeed())
 }
 
diff --git a/pkg/prometheus/prometheus.go b/pkg/prometheus/prometheus.go
@@ -171,6 +171,7 @@ func (s *Server) Start(ctx context.Context) error {
 	errCh := make(chan error)
 	drain := func() {
 		for range errCh {
+			continue
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ func (c *TestClient) Create(ctx context.Context, obj client.Object, opts ...Requ`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`-func (c *TestClient) Update(ctx context.Context, obj client.Object, opts ...RequestOption) {`
	`30`	`+func (c *TestClient) Update(ctx context.Context, obj client.Object, _ ...RequestOption) {`
`31`	`31`	`gomega.ExpectWithOffset(1, c.client.Update(ctx, obj)).Should(gomega.Succeed())`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,7 @@ func (s *Server) Start(ctx context.Context) error {`
`171`	`171`	`errCh := make(chan error)`
`172`	`172`	`drain := func() {`
`173`	`173`	`for range errCh {`
	`174`	`+ continue`
`174`	`175`	`}`
`175`	`176`	`}`
`176`	`177`