Skip to content

Invalid podman arguments in makefile #3652

@mshriver

Description

@mshriver

The Makefile includes automatic use of podman, but includes an option that is not accepted by podman.

https://github.com/app-sre/qontract-reconcile/blob/master/Makefile#L68

This argument is not valid for podman:

--add-host=host.docker.internal:host-gateway

And creates the following failure mode when dev-reconcile-loop is used:

Error: invalid IP address in add-host: "host-gateway"

Currently playing with what would be valid arguments for podman runtime. It ties into qontract-server makefile as well, since that runs the server with direct port bindings. Maybe both using an expected podman network would be a preferable solution, although it looks like the argument isn't needed at all when running in podman, or the --network host argument can be used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions