Do bounds check in WeightBuffer

appgurueu · appgurueu · commit 24673c86e8c2 · 2025-11-23T00:54:01.000+01:00
diff --git a/irr/src/SkinnedMesh.cpp b/irr/src/SkinnedMesh.cpp
@@ -399,9 +399,6 @@ SkinnedMesh *SkinnedMeshBuilder::finalize() &&
 		auto *buf = mesh->LocalBuffers.at(weight.buffer_id);
 		if (!buf->Weights)
 			buf->Weights = WeightBuffer(buf->getVertexCount());
-		if (weight.vertex_id >= buf->Weights->size()) {
-			throw std::out_of_range("vertex id out of range");
-		}
 		buf->Weights->addWeight(weight.vertex_id, weight.joint_id, weight.strength);
 	}
 
diff --git a/irr/src/WeightBuffer.cpp b/irr/src/WeightBuffer.cpp
@@ -21,7 +21,7 @@ void WeightBuffer::VertexWeights::addWeight(u16 joint_id, f32 weight)
 
 void WeightBuffer::addWeight(u32 vertex_id, u16 joint_id, f32 weight)
 {
-	weights[vertex_id].addWeight(joint_id, weight);
+	weights.at(vertex_id).addWeight(joint_id, weight);
 }
 
 void WeightBuffer::VertexWeights::skinVertex(core::vector3df &pos, core::vector3df &normal,

Original file line number	Diff line number	Diff line change
`@@ -399,9 +399,6 @@ SkinnedMesh *SkinnedMeshBuilder::finalize() &&`
`399`	`399`	`auto *buf = mesh->LocalBuffers.at(weight.buffer_id);`
`400`	`400`	`if (!buf->Weights)`
`401`	`401`	`buf->Weights = WeightBuffer(buf->getVertexCount());`
`402`		`- if (weight.vertex_id >= buf->Weights->size()) {`
`403`		`- throw std::out_of_range("vertex id out of range");`
`404`		`- }`
`405`	`402`	`buf->Weights->addWeight(weight.vertex_id, weight.joint_id, weight.strength);`
`406`	`403`	`}`
`407`	`404`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ void WeightBuffer::VertexWeights::addWeight(u16 joint_id, f32 weight)`
`21`	`21`
`22`	`22`	`void WeightBuffer::addWeight(u32 vertex_id, u16 joint_id, f32 weight)`
`23`	`23`	`{`
`24`		`- weights[vertex_id].addWeight(joint_id, weight);`
	`24`	`+ weights.at(vertex_id).addWeight(joint_id, weight);`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`void WeightBuffer::VertexWeights::skinVertex(core::vector3df &pos, core::vector3df &normal,`