refactor: use FBDoesElementSupportInnerText and clarify helper method comment

- Replaced custom placeholder support check with FBDoesElementSupportInnerText, as introduced in upstream PR
- Updated comment for fb_attributeBlockMapForSnapshot to clarify usage context and avoid confusion about method placement

Author: ikharebashviliGD

WebDriverAgentLib/Categories/FBXCElementSnapshotWrapper+Helpers.h

@@ -96,11 +96,6 @@ NS_ASSUME_NONNULL_BEGIN
  */
 - (nullable NSValue *)fb_hitPoint;
 
-/**
- @return YES,  if the element type is one that supports placeholder text
- */
-- (BOOL)fb_supportsPlaceholder;
-
 @end
 
 NS_ASSUME_NONNULL_END

WebDriverAgentLib/Categories/FBXCElementSnapshotWrapper+Helpers.m

@@ -162,13 +162,6 @@ - (NSValue *)fb_hitPoint
   return [NSValue valueWithCGPoint:result.hitPoint];
 }
 
-- (BOOL)fb_supportsPlaceholder {
-  XCUIElementType elementType = self.elementType;
-  return elementType == XCUIElementTypeTextField
-    || elementType == XCUIElementTypeSearchField
-    || elementType == XCUIElementTypeSecureTextField;
-}
-
 @end
 
 inline static BOOL isSnapshotTypeAmongstGivenTypes(id<FBXCElementSnapshot> snapshot, NSArray<NSNumber *> *types)

WebDriverAgentLib/Categories/XCUIApplication+FBHelpers.m

@@ -37,6 +37,7 @@
 #import "XCUIElement+FBUtilities.h"
 #import "XCUIElement+FBWebDriverAttributes.h"
 #import "XCUIElementQuery.h"
+#import "FBElementHelpers.h"
 
 static NSString* const FBUnknownBundleId = @"unknown";
 
@@ -202,7 +203,7 @@ + (NSDictionary *)dictionaryForElement:(id<FBXCElementSnapshot>)snapshot
   info[@"label"] = FBValueOrNull(wrappedSnapshot.wdLabel);
   info[@"rect"] = wrappedSnapshot.wdRect;
 
-  NSMutableDictionary<NSString *, NSString *(^)(void)> *attributeBlocks = [self attributeBlockMapForSnapshot:snapshot
+  NSDictionary<NSString *, NSString *(^)(void)> *attributeBlocks = [self fb_attributeBlockMapForSnapshot:snapshot
                                                                                 wrappedSnapshot:wrappedSnapshot];
 
   NSSet *nonPrefixedKeys = [NSSet setWithObjects:FBExclusionAttributeFrame,
@@ -237,9 +238,9 @@ + (NSDictionary *)dictionaryForElement:(id<FBXCElementSnapshot>)snapshot
   return info;
 }
 
-// Private helper that builds all attribute blocks for a given snapshot.
-// Includes both base attributes and any element-specific ones (e.g. placeholder for text inputs, etc.).
-+ (NSMutableDictionary<NSString *, NSString *(^)(void)> *)attributeBlockMapForSnapshot:(id<FBXCElementSnapshot>)snapshot
+// Helper used by `dictionaryForElement:` to assemble attribute value blocks,
+// including both common attributes and conditionally included ones like placeholderValue.
++ (NSDictionary<NSString *, NSString *(^)(void)> *)fb_attributeBlockMapForSnapshot:(id<FBXCElementSnapshot>)snapshot
                                                                        wrappedSnapshot:(FBXCElementSnapshotWrapper *)wrappedSnapshot
 {
   // Base attributes common to every element
@@ -262,14 +263,16 @@ + (NSDictionary *)dictionaryForElement:(id<FBXCElementSnapshot>)snapshot
   }
   } mutableCopy];
 
+  XCUIElementType elementType = wrappedSnapshot.elementType;
+  
   // Text-input placeholder (only for elements that support inner text)
-  if ([wrappedSnapshot fb_supportsPlaceholder]) {
+  if (FBDoesElementSupportInnerText(elementType)) {
     blocks[FBExclusionAttributePlaceholderValue] = ^{
       return (NSString *)FBValueOrNull(wrappedSnapshot.wdPlaceholderValue);
     };
   }
 
-  return blocks;
+  return [blocks copy];
 }
 
 + (NSDictionary *)accessibilityInfoForElement:(id<FBXCElementSnapshot>)snapshot