Add partial xpath support to ignore identifiers in the axpath #110
Conversation
| { | ||
| return rootUIElement; | ||
| } | ||
| calls++; |
There was a problem hiding this comment.
what the calls variable for?
| [matchedChildren addObject:foundElement]; | ||
| } | ||
|
|
||
| return matchedChildren; |
There was a problem hiding this comment.
matchedChildren.copy
| NSMutableArray *matchedChildren = [NSMutableArray array]; | ||
| PFUIElement* foundElement = [self findElementRecursively:rootUIElement calls:0]; | ||
|
|
||
| if ([foundElement isNotEqualTo:nil]) |
There was a problem hiding this comment.
cannot we simply use == for comparison here?
| return @[]; | ||
| } | ||
|
|
||
| -(PFUIElement*) findElementRecursively:(PFUIElement *)rootUIElement calls:(int)calls |
There was a problem hiding this comment.
it always make sense to mention nullability in method signatures
| return matchedChildren; | ||
| } | ||
|
|
||
| -(void) setRoleAndPredicatesOfElement:(NSString*) elementToFind |
There was a problem hiding this comment.
This class seems overloaded with different stuff. Would it be possible to extract lookup-specific stuff into a separate class/category? Even better, add some basic unit tests to it?
|
|
||
| NSArray* predicateArray = parseElement[kNodePredicate][kPredicateOperations]; | ||
|
|
||
| for (int i=0; i < [predicateArray count]; i++) |
There was a problem hiding this comment.
cannot we simple iterate over array items (for-in)?
| { | ||
| id object = [predicateArray objectAtIndex:i]; | ||
| NSString* attributeName = object[kPredicateAttributeName]; | ||
| NSString* attributeValue = object[kPredicateAttributeValue]; |
There was a problem hiding this comment.
attributeValue only should be extracted inside of if block
|
|
||
| for (int i=0; i < [predicateArray count]; i++) | ||
| { | ||
| id object = [predicateArray objectAtIndex:i]; |
There was a problem hiding this comment.
is it possible to have better name for this variable?
2 participants
In the desktop application we have, the AXIdentifier part keeps changing and this results in test case failures.
Adding partial xpath support which will ignore the identifiers and will search for the element recursively