Skip to content

Commit eebd293

Browse files
committed
Fix image resolution pipeline
1 parent 2899c06 commit eebd293

2 files changed

Lines changed: 1 addition & 11 deletions

File tree

pkg/build/frontend.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func resolveStates(ctx context.Context, bopts *BOpts, platform ocispecs.Platform
165165
resolverOpts.ImageOpt = &sourceresolver.ResolveImageOpt{
166166
ResolveMode: llb.ResolveModePreferLocal.String(),
167167
}
168-
_, digest, img, err := bopts.Resolver.ResolveImageConfig(ctx, ref.String(), resolverOpts)
168+
_, digest, img, err := bopts.Resolver.ResolveImageConfig(ctx, resolvedBaseStageName.Result, resolverOpts)
169169
if err != nil {
170170
if err == reference.ErrObjectRequired {
171171
return

pkg/resolver/resolver.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,10 @@ import (
2121
"fmt"
2222

2323
"github.com/containerd/containerd/platforms"
24-
"github.com/containerd/containerd/reference"
2524
"github.com/google/uuid"
2625
"github.com/moby/buildkit/client/llb"
2726
"github.com/moby/buildkit/client/llb/sourceresolver"
2827
"github.com/opencontainers/go-digest"
29-
"github.com/sirupsen/logrus"
3028

3129
"github.com/apple/container-builder-shim/pkg/api"
3230
"github.com/apple/container-builder-shim/pkg/stream"
@@ -119,14 +117,6 @@ Response Format:
119117
*/
120118
func (r *ResolverProxy) ResolveImageConfig(ctx context.Context, ref string, opt sourceresolver.Opt) (string, digest.Digest, []byte, error) {
121119
var err error
122-
u, err := reference.Parse(ref)
123-
if err != nil {
124-
logrus.Debugf("reference parse error: %v", err)
125-
return ref, digest.Digest(""), nil, err
126-
} else if u.Object == "" {
127-
logrus.Debugf("reference object empty: %#v", u)
128-
return ref, digest.Digest(""), nil, reference.ErrObjectRequired
129-
}
130120

131121
req := &api.ImageTransfer{
132122
Direction: api.TransferDirection_INTO,

0 commit comments

Comments
 (0)