Skip to content

Commit 3efbf4a

Browse files
committed
Minor fix to ManagedResource.
1 parent d7b61cc commit 3efbf4a

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

Sources/ContainerResource/Common/ManagedResource.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public protocol ManagedResource: Identifiable, Sendable, Codable {
4444

4545
extension ManagedResource {
4646
/// Generate a random identifier that has the format of an ASCII SHA-256 hash.
47-
public static func randomId() -> String {
47+
public static func generateId() -> String {
4848
(0..<2)
4949
.map { _ in UInt128.random(in: 0...UInt128.max) }
5050
.map { String($0, radix: 16).padding(toLength: 32, withPad: "0", startingAt: 0) }

Tests/ContainerResourceTests/ManagedResourceTests.swift

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,14 @@ struct ManagedResourceTests {
2828
var creationDate: Date
2929
var labels: [String: String]
3030

31-
static func generateId() -> String {
32-
randomId()
33-
}
34-
3531
static func nameValid(_ name: String) -> Bool {
3632
true
3733
}
3834
}
3935

4036
@Test("randomId generates valid hex string SHA256 hash format")
4137
func testRandomIdFormat() {
42-
let id = MockManagedResource.randomId()
38+
let id = MockManagedResource.generateId()
4339

4440
// SHA256 hash is 64 hex characters (256 bits / 4 bits per hex char)
4541
#expect(id.count == 64, "randomId should generate 64 character string")
@@ -55,15 +51,15 @@ struct ManagedResourceTests {
5551
@Test("randomId generates unique values")
5652
func testRandomIdUniqueness() {
5753
// Generate multiple IDs and verify they're all different
58-
let ids = (0..<100).map { _ in MockManagedResource.randomId() }
54+
let ids = (0..<100).map { _ in MockManagedResource.generateId() }
5955
let uniqueIds = Set(ids)
6056

6157
#expect(uniqueIds.count == 100, "All generated IDs should be unique")
6258
}
6359

6460
@Test("randomId uses lowercase hexadecimal")
6561
func testRandomIdLowercase() {
66-
let id = MockManagedResource.randomId()
62+
let id = MockManagedResource.generateId()
6763

6864
// Should not contain uppercase letters
6965
let uppercaseLetters = CharacterSet.uppercaseLetters

0 commit comments

Comments
 (0)