Skip to content

Commit 9dc84cf

Browse files
poetryofcodeclaude
andcommitted
Warn user when a named volume is auto-created
When a container references a named volume that doesn't exist, it is silently created. This adds a warning message so users are aware of the implicit resource creation, addressing the TODO in Utility.swift. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent fdeb1b1 commit 9dc84cf

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

Sources/Services/ContainerAPIService/Client/Utility.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,15 @@ public struct Utility {
347347
let labels = parsed.isAnonymous ? [Volume.anonymousLabel: ""] : [:]
348348

349349
let volume: Volume
350+
var wasCreated = false
350351
do {
351352
volume = try await ClientVolume.create(
352353
name: parsed.name,
353354
driver: "local",
354355
driverOpts: [:],
355356
labels: labels
356357
)
358+
wasCreated = true
357359
} catch let error as VolumeError {
358360
guard case .volumeAlreadyExists = error else {
359361
throw error
@@ -368,7 +370,9 @@ public struct Utility {
368370
volume = try await ClientVolume.inspect(parsed.name)
369371
}
370372

371-
// TODO: Warn user if named volume was auto-created
373+
if wasCreated && !parsed.isAnonymous {
374+
print("Warning: volume \"\(parsed.name)\" not found, auto-created")
375+
}
372376

373377
return volume
374378
}

0 commit comments

Comments
 (0)