Skip to content

Commit 7359653

Browse files
Remove image push tests (#55)
This removes two image push tests. We cannot have the CI push to our ghcr registry since external users do not have write access for pushing the image. We will explore a better solution. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
1 parent 2923b33 commit 7359653

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

Tests/ContainerizationOCITests/RegistryClientTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ struct OCIClientTests: ~Copyable {
166166
#expect(done)
167167
}
168168

169-
@Test(.enabled(if: hasRegistryCredentials))
169+
@Test(.disabled("External users cannot push images, disable while we find a better solution"))
170170
func pushIndex() async throws {
171171
let client = RegistryClient(host: "ghcr.io", authentication: Self.authentication)
172172
let indexDescriptor = try await client.resolve(name: "apple/containerization/emptyimage", tag: "0.0.1")

Tests/ContainerizationTests/ImageTests/ImageStoreTests.swift

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,14 @@ public class ImageStoreTests: ContainsAuth {
7272

7373
let tempFile = self.dir.appending(path: "export.tar")
7474
try await self.store.save(references: [imageReference, expectedLoadedImage], out: tempFile)
75+
}
76+
77+
@Test(.disabled("External users cannot push images, disable while we find a better solution"))
78+
func testImageStorePush() async throws {
79+
guard let authentication = Self.authentication else {
80+
return
81+
}
82+
let imageReference = "ghcr.io/apple/containerization/dockermanifestimage:0.0.2"
7583

7684
let remoteImageName = "ghcr.io/apple/test-images/image-push"
7785
let epoch = Int(Date().timeIntervalSince1970.description)

0 commit comments

Comments
 (0)