Makefile: Revert recent reworking - #177
Merged
Merged
Conversation
dcantah
force-pushed
the
revert-mkfile-additions
branch
from
June 26, 2025 18:42
91a307c to
1af5aa4
Compare
dcantah
marked this pull request as draft
June 26, 2025 18:42
dcantah
force-pushed
the
revert-mkfile-additions
branch
from
June 26, 2025 20:31
1af5aa4 to
f46d480
Compare
This reverts commit f9198d6.
dcantah
force-pushed
the
revert-mkfile-additions
branch
from
June 26, 2025 21:32
f46d480 to
555cde6
Compare
dcantah
marked this pull request as ready for review
June 26, 2025 21:32
adityaramani
approved these changes
Jun 26, 2025
Some of the targets rely on others but weren't actually listed: - init relies on containerization as it invokes cctl. - integration relies on init as it needs the rootfs with vminitd inside.
dcantah
force-pushed
the
revert-mkfile-additions
branch
from
June 26, 2025 22:57
555cde6 to
280af87
Compare
crosbymichael
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts f9198d6
We can explore better approaches to some of the targets, but for now lets revert as it interferes with being able to build even if we have local changes.