Skip to content

Commit 61d7084

Browse files
authored
test: unskip Graph CoreML export tests as segfault no longer occurs (#35)
test: unskip pt2e coreml export test as segfault no longer occurs Verified across interpreter and all three CoreML delegates (CPU/BNNS, GPU/MPSGraph, ANE) in both parallel and serial pytest runs that the uint8/per-tensor/asymmetric quantization config no longer segfaults.
1 parent 0eabc57 commit 61d7084

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

tests/export/test_pt2e_mil_export.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
for qscheme in QuantizationScheme
8080
]
8181
+ [
82-
# uint8 asymmetric per-tensor - crashes with segfault
82+
# uint8 weights with per-tensor granularity, asymmetric qscheme
8383
(
8484
torch.uint8,
8585
PerTensorGranularity(),
@@ -102,22 +102,9 @@
102102
_test_params_with_xfail: list = []
103103
for params in _test_params:
104104
dtype, wg, ag, qscheme = params
105-
# uint8 asymmetric per-tensor crashes with segfault
106-
if (
107-
dtype == torch.uint8
108-
and isinstance(wg, PerTensorGranularity)
109-
and isinstance(ag, PerTensorGranularity)
110-
and qscheme == QuantizationScheme.ASYMMETRIC
111-
):
112-
_test_params_with_xfail.append(
113-
pytest.param(
114-
*params,
115-
marks=pytest.mark.skip(reason="Crashes with segfault"),
116-
),
117-
)
118105
# Per-channel activation with negative axis has SNR below threshold.
119106
# TODO: SNR below threshold for per-channel activation with negative axis on CoreML export.
120-
elif isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0:
107+
if isinstance(ag, PerChannelGranularity) and ag.axis is not None and ag.axis < 0:
121108
_test_params_with_xfail.append(
122109
pytest.param(
123110
*params,

0 commit comments

Comments
 (0)