From ba15e861b46e0fe447375aa987d8149cf0251066 Mon Sep 17 00:00:00 2001 From: Guru Deshpande <66385690+guru-desh@users.noreply.github.com> Date: Mon, 13 Jul 2026 11:45:33 -0700 Subject: [PATCH] test: unskip eager CoreML int8-activation export tests as they now pass COREML_SUPPORTED_ACTIVATION_DTYPES already includes torch.int8 (src/coreai_opt/_utils/export_utils.py), and the CoreML rejection test (test_unsupported_activation_quant_coreml_export_rejected) already excludes int8 from its rejection list. The skip_if_unsupported guards in test_simple_model_export and test_mnist_export were stale relative to the source's own dtype-support contract. Verified all 216 previously-skipped configs now pass (CPU_ONLY, the only compute path this test file exercises). --- tests/export/test_eager_mil_export.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/tests/export/test_eager_mil_export.py b/tests/export/test_eager_mil_export.py index 10835f1..6ab3eb9 100644 --- a/tests/export/test_eager_mil_export.py +++ b/tests/export/test_eager_mil_export.py @@ -94,13 +94,6 @@ def test_simple_model_export( parametrized_quant_config_general: ParametrizedQuantConfigs, ) -> None: """Test eager CoreML export with various quantization configurations.""" - # CoreML doesn't support int8 activation quantization - parametrized_quant_config_general.skip_if_unsupported( - "eager", - ExportBackend.CoreML, - unsupported_configs={"backend": ExportBackend.CoreML, "act_dtype": torch.int8}, - ) - has_act_quant = parametrized_quant_config_general.has_activation_quantization _run_eager_mil_export_test( @@ -121,13 +114,6 @@ def test_mnist_export( parametrized_quant_config_general: ParametrizedQuantConfigs, ) -> None: """Test eager CoreML export on MNIST model with various quantization configurations.""" - # CoreML doesn't support int8 activation quantization - parametrized_quant_config_general.skip_if_unsupported( - "eager", - ExportBackend.CoreML, - unsupported_configs={"backend": ExportBackend.CoreML, "act_dtype": torch.int8}, - ) - has_act_quant = parametrized_quant_config_general.has_activation_quantization _run_eager_mil_export_test(