Skip to content

Commit c289917

Browse files
authored
Update the default version of the Dockerfile and remove 6.3 (#12158)
* Update the default version of the Dockerfile and remove 6.3
1 parent 8b7ac8a commit c289917

File tree

3 files changed

+32
-13
lines changed

3 files changed

+32
-13
lines changed

packaging/docker/Dockerfile

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# See the License for the specific language governing permissions and
1717
# limitations under the License.
1818
#
19-
FROM docker.io/rockylinux/rockylinux:9.4-minimal AS base
19+
FROM docker.io/rockylinux/rockylinux:9.5-minimal AS base
2020

2121
RUN microdnf install -y \
2222
bind-utils \
@@ -57,11 +57,14 @@ RUN curl -Ls "https://github.com/krallin/tini/releases/download/v0.19.0/tini-$TA
5757

5858
WORKDIR /
5959

60-
FROM docker.io/library/golang:1.23.8-bullseye AS go-build
61-
60+
FROM docker.io/library/golang:1.23.9-bookworm AS go-build
6261
COPY fdbkubernetesmonitor/ /fdbkubernetesmonitor
6362
WORKDIR /fdbkubernetesmonitor
6463
RUN go build -o /fdb-kubernetes-monitor *.go
64+
65+
# Build the fdb-aws-s3-credentials-fetcher in a dedicated build as we don't want to build this image
66+
# on a regular base until we have a release plan for it.
67+
FROM go-build AS go-credentials-fetcher-build
6568
COPY fdb-aws-s3-credentials-fetcher/ /fdb-aws-s3-credentials-fetcher
6669
WORKDIR /fdb-aws-s3-credentials-fetcher
6770
RUN go build -o /fdb-aws-s3-credentials-fetcher *.go
@@ -75,12 +78,11 @@ RUN groupadd --gid 4059 fdb && \
7578
--no-create-home \
7679
--shell /bin/bash fdb
7780
USER fdb
78-
COPY --from=go-build /fdb-aws-s3-credentials-fetcher /usr/bin/
81+
COPY --from=go-credentials-fetcher-build /fdb-aws-s3-credentials-fetcher /usr/bin/
7982
ENTRYPOINT ["/usr/bin/fdb-aws-s3-credentials-fetcher", "-dir", "/var/fdb"]
8083

8184
FROM base AS foundationdb-base
82-
83-
ARG FDB_VERSION=6.3.22
85+
ARG FDB_VERSION=7.3.63
8486
ARG FDB_LIBRARY_VERSIONS="${FDB_VERSION}"
8587
ARG FDB_WEBSITE=https://github.com/apple/foundationdb/releases/download
8688

@@ -228,7 +230,7 @@ RUN if [ "$TARGETARCH" = "amd64" ]; then \
228230

229231
# TODO: Log4J complains that it's eating the HTracer logs. Even without it, we get per-operation
230232
# time series graphs of throughput, median, 90, 99, 99.9 and 99.99 (in usec).
231-
COPY run_ycsb.sh run_ycsb_standalone.sh /usr/local/bin
233+
COPY run_ycsb.sh run_ycsb_standalone.sh /usr/local/bin/
232234
RUN mkdir -p /var/log/fdb-trace-logs && \
233235
chmod +x /usr/local/bin/run_ycsb.sh && \
234236
chmod +x /usr/local/bin/run_ycsb_standalone.sh

packaging/docker/README.md

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,30 @@
11
# packaging/docker
2-
This directory contains the pieces for building FoundationDB docker images.
2+
3+
This directory contains the pieces for building FoundationDB docker images.
34

45
`build-images.sh` will optionally take a single parameter that will be used as an
56
image tag postfix.
67

78
For more details it is best to read the `build-images.sh` shell script itself to
8-
learn more about how the images are built.
9+
learn more about how the images are built.
10+
11+
For details about what is in the images, peruse `Dockerfile`
12+
13+
the `samples` directory is out of date, and anything therein should be used with
14+
the expectation that it is, at least, partially (if not entirely) incorrect.
15+
16+
## Building images locally without the script
17+
18+
If you only want to build a custom container image based on an alrady released FDB version you run the following command from the root:
19+
20+
```bash
21+
export FDB_VERSION=7.3.63
22+
docker build --build-arg FDB_VERSION=${FDB_VERSION} -t ${REGISTRY}/foundationdb/fdb-kubernetes-monitor:${FDB_VERSION} --target fdb-kubernetes-monitor -f ./packaging/docker/Dockerfile .
23+
```
924

10-
For details about what is in the images, peruse `Dockerfile{,.eks}`
25+
Or if you want to build the `foundationdb` image and not the `fdb-kubernetes-monitor`:
1126

12-
the `samples` directory is out of date, and anything therein should be used with
13-
the expectation that it is, at least, partially (if not entirely) incorrect.
27+
```bash
28+
export FDB_VERSION=7.3.63
29+
docker build --build-arg FDB_VERSION=${FDB_VERSION} -t ${REGISTRY}/foundationdb/foundationdb:${FDB_VERSION} --target foundationdb -f ./packaging/docker/Dockerfile .
30+
```

packaging/docker/build-images.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ build_output_directory="${script_dir}/../../"
250250
source_code_diretory=$(awk -F= '/foundationdb_SOURCE_DIR:STATIC/{print $2}' "${build_output_directory}/CMakeCache.txt")
251251
commit_sha=$(cd "${source_code_diretory}" && git rev-parse --verify HEAD --short=10)
252252
fdb_version=$(cat "${build_output_directory}/version.txt")
253-
fdb_library_versions=( '6.3.25' '7.1.57' '7.3.37' "${fdb_version}" )
253+
fdb_library_versions=( '7.3.63' "${fdb_version}" )
254254
fdb_website="https://github.com/apple/foundationdb/releases/download"
255255
image_list=(
256256
'base'

0 commit comments

Comments
 (0)