Fix error rendering @ConvertProperty annotations during error reporting

Author: HT154

pkl-core/src/main/java/org/pkl/core/runtime/VmUndefinedValueException.java

@@ -74,7 +74,7 @@ public VmUndefinedValueException fillInHint(Deque<Object> path, Object topLevelV
     if (topLevelValue instanceof VmTyped typed && typed.isModuleObject()) {
       builder
           .append(" of module `")
-          .append(typed.getModuleInfo().getModuleSchema(typed).getModuleUri())
+          .append(typed.getModuleInfo().getModuleKey().getUri())
           .append('`');
     }
     builder.append('.');

pkl-core/src/test/files/LanguageSnippetTests/input/errors/convertProperty1.pkl

@@ -0,0 +1,20 @@
+class WrapTypeWithName extends ConvertProperty {
+  // render: (Pair<String, Any>, BaseValueRenderer) -> Pair<String, Any>
+  render = (p, _) ->
+    Pair(p.key, new Mapping {
+      [p.value.getClass().simpleName] = p.value
+    })
+}
+
+class Something {
+  @WrapTypeWithName
+  prop1: String
+  prop2: Int
+}
+
+a: Something = new Something {
+  prop2 = 1
+}
+
+// this should result in: Tried to read property `prop1` but its value is undefined.
+// any other error would result from an error in the reporting path

pkl-core/src/test/files/LanguageSnippetTests/output/errors/convertProperty1.err

@@ -0,0 +1,16 @@
+–– Pkl Error ––
+Tried to read property `prop1` but its value is undefined.
+
+xx | prop1: String
+     ^^^^^
+at convertProperty1#Something.prop1 (file:///$snippetsDir/input/errors/convertProperty1.pkl)
+
+The above error occurred when rendering path `a.prop1` of module `file:///$snippetsDir/input/errors/convertProperty1.pkl`.
+
+xxx | renderer.renderDocument(value)
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+at pkl.base#Module.output.text (pkl:base)
+
+xxx | if (renderer is BytesRenderer) renderer.renderDocument(value) else text.encodeToBytes("UTF-8")
+                                                                         ^^^^
+at pkl.base#Module.output.bytes (pkl:base)

stdlib/base.pkl

@@ -414,7 +414,7 @@ abstract class BaseValueRenderer {
 open class ConvertProperty extends Annotation {
   /// Function called by [BaseValueRenderer] types during rendering to transform property
   /// names and values.
-  render: (Pair<String, Any>, BaseValueRenderer) -> Pair<String, Any>
+  hidden render: (Pair<String, Any>, BaseValueRenderer) -> Pair<String, Any>
 }
 
 /// Base class for rendering Pkl values in some textual output format.