Skip to content

Commit f22537f

Browse files
authored
Do not run benchmarks on linux, we can’t collect anything anyway (#415)
`swift-nio` reusable workflow for running benchmarks has been recently fixed and now linux benchmarks are failing because we do not have any thresholds recorded. The main purpose for `swift-log` benchmarks is to keep track of the amount of instructions and on linux runners performance metrics are not available, so we cannot check the relevant metric. Let's remove them.
1 parent 185a56a commit f22537f

File tree

2 files changed

+0
-27
lines changed

2 files changed

+0
-27
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,6 @@ jobs:
3030
windows_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
3131
windows_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
3232

33-
benchmarks:
34-
name: Benchmarks (NoTraits)
35-
uses: apple/swift-nio/.github/workflows/benchmarks.yml@main
36-
with:
37-
benchmark_package_path: "Benchmarks/NoTraits"
38-
3933
macos-benchmarks:
4034
name: macOS benchmarks (NoTraits)
4135
uses: apple/swift-nio/.github/workflows/macos_benchmarks.yml@main
@@ -44,13 +38,6 @@ jobs:
4438
macos_xcode_16_4_enabled: true
4539
macos_xcode_26_1_enabled: true
4640

47-
benchmarks-MaxLogLevelWarningBenchmarks-trait:
48-
name: Benchmarks (MaxLogLevelWarning)
49-
needs: benchmarks
50-
uses: apple/swift-nio/.github/workflows/benchmarks.yml@main
51-
with:
52-
benchmark_package_path: "Benchmarks/MaxLogLevelWarning"
53-
5441
macos-benchmarks-MaxLogLevelWarningBenchmarks-trait:
5542
name: macOS benchmarks (MaxLogLevelWarning)
5643
needs: macos-benchmarks

.github/workflows/pull_request.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,6 @@ jobs:
3434
windows_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
3535
windows_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
3636

37-
benchmarks:
38-
name: Benchmarks (NoTraits)
39-
uses: apple/swift-nio/.github/workflows/benchmarks.yml@main
40-
with:
41-
benchmark_package_path: "Benchmarks/NoTraits"
42-
4337
macos-benchmarks:
4438
name: macOS benchmarks (NoTraits)
4539
uses: apple/swift-nio/.github/workflows/macos_benchmarks.yml@main
@@ -49,14 +43,6 @@ jobs:
4943
macos_xcode_16_4_enabled: true
5044
macos_xcode_26_1_enabled: true
5145

52-
benchmarks-MaxLogLevelWarningBenchmarks-trait:
53-
name: Benchmarks (MaxLogLevelWarning)
54-
# Workaround for reusing the same benchmarks.yml workflow
55-
needs: benchmarks
56-
uses: apple/swift-nio/.github/workflows/benchmarks.yml@main
57-
with:
58-
benchmark_package_path: "Benchmarks/MaxLogLevelWarning"
59-
6046
macos-benchmarks-MaxLogLevelWarningBenchmarks-trait:
6147
name: macOS benchmarks (MaxLogLevelWarning)
6248
# Workaround for reusing the same benchmarks.yml workflow

0 commit comments

Comments
 (0)