Merge branch 'main' into sb/channel-underlying-transport

Author: simonjbeaumont

Benchmarks/Package.swift

@@ -9,7 +9,7 @@ let package = Package(
     ],
     dependencies: [
         .package(path: "../"),
-        .package(url: "https://github.com/ordo-one/package-benchmark.git", from: "1.22.0"),
+        .package(url: "https://github.com/ordo-one/package-benchmark.git", from: "1.29.11"),
     ],
     targets: [
         .executableTarget(

Sources/NIOPosix/SelectableEventLoop.swift

@@ -137,7 +137,7 @@ internal final class SelectableEventLoop: EventLoop, @unchecked Sendable {
     // This may only be read/written while holding the _tasksLock.
     internal var _pendingTaskPop = false
     @usableFromInline
-    internal var scheduledTaskCounter = ManagedAtomic<UInt64>(0)
+    internal let scheduledTaskCounter = ManagedAtomic<UInt64>(0)
     @usableFromInline
     internal var _scheduledTasks = PriorityQueue<ScheduledTask>()
     @usableFromInline

scripts/check_benchmark_thresholds.sh

@@ -35,12 +35,27 @@ swift package --package-path "$benchmark_package_path" "${swift_package_argument
 rc="$?"
 
 # Benchmarks are unchanged, nothing to recalculate
-if [[ "$rc"  == 0 ]]; then
+if [[ "$rc" == 0 ]]; then
   exit 0
+# Benchmark thresholds changed – 2 is defined in
+#   package-benchmark/BenchmarkShared/Command+Helpers.swift/ExitCode.thresholdRegression
+elif [[ "$rc" == 2 ]]; then
+  log "Recalculating thresholds..."
+
+  swift package --package-path "$benchmark_package_path" "${swift_package_arguments[@]}" benchmark thresholds update --format metricP90AbsoluteThresholds --path "${benchmark_package_path}/Thresholds/${swift_version}/"
+  update_rc="$?"
+
+  if [[ "$update_rc" != 0 ]]; then
+    error "Benchmark failed to run due to build error."
+    exit $update_rc
+  fi
+
+  echo "=== BEGIN DIFF ==="  # use echo, not log for clean output to be scraped
+  git diff --exit-code HEAD
+# all other errors
+else
+  error "Benchmark failed to run due to build error."
+  exit $rc
 fi
 
-log "Recalculating thresholds..."
 
-swift package --package-path "$benchmark_package_path" "${swift_package_arguments[@]}" benchmark thresholds update --format metricP90AbsoluteThresholds --path "${benchmark_package_path}/Thresholds/${swift_version}/"
-echo "=== BEGIN DIFF ==="  # use echo, not log for clean output to be scraped
-git diff --exit-code HEAD